1167395 - Mark CharacterDataChangeInfo::Details as MOZ_STACK_CLASS, and mark mNextSibling as MOZ_NON_OWNING_REF

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=45b0d7290868

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Change CharacterDataChangeInfo::mNextSibling to a smart pointer

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8609014 [details] [diff] [review]
Change CharacterDataChangeInfo::mNextSibling to a smart pointer

I took a look at this bug as I bounced it over to you.

I think that there is a very good chance that it isn't correct, I can't remember if I actually traced through every user to make sure that there are no cycles, but the relationships through DXR don't look super easy to trace through.

Tests did pass with the change though, so maybe it's OK? If you know how this is used, I can probably use that information to get a better idea of whether or not the change will introduce a memory leak.

Comment 3

[(no longer active)]

Comment on attachment 8609014 [details] [diff] [review]
Change CharacterDataChangeInfo::mNextSibling to a smart pointer

Review of attachment 8609014 [details] [diff] [review]:
-----------------------------------------------------------------

I think Olli is a better reviewer for this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

CharacterDataChangeInfo::Details is a stack only struct (although it isn't marked as such), so I don't see any reason to
slow down the current behavior.
I would mark the variable MOZ_NON_OWNING_REF.
Also, I checked the current usage, and it is definitely safe.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark CharacterDataChangeInfo::Details as MOZ_STACK_CLASS, and mark mNextSibling as MOZ_NON_OWNING_REF

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8629530 [details] [diff] [review]
Mark CharacterDataChangeInfo::Details as MOZ_STACK_CLASS, and mark mNextSibling as MOZ_NON_OWNING_REF

Thanks

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78d7bfaf3fc1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78d7bfaf3fc1