Closed Bug 1167402 Opened 5 years ago Closed 5 years ago

Mark nsPresContext::mLinkHandler as MOZ_NON_OWNING_REF

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Attachment #8609019 - Flags: review?(dbaron)
Blocks: 1114683
Could you explain what steps you took to convince yourself that this patch won't introduce new leaks?
Flags: needinfo?(michael)
In retrospect, this should have been a MOZ_NON_OWNING_REF. Thanks for making me look closer at it :).

I'll push an updated patch.
Flags: needinfo?(michael)
Assignee: nobody → michael
Comment on attachment 8612320 [details] [diff] [review]
Make nsPresContext::mLinkHandler a smart pointer

Please fix the commit message and the bug summary to reflect that
you're now marking it MOZ_NON_OWNING_REF.

r=dbaron
Attachment #8612320 - Flags: review?(dbaron) → review+
Oops commit message
Attachment #8612320 - Attachment is obsolete: true
Keywords: checkin-needed
Summary: Make nsPresContext::mLinkHandler a smart pointer → Mark nsPresContext::mLinkHandler as MOZ_NON_OWNING_REF
https://hg.mozilla.org/mozilla-central/rev/9052882b9330
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.