1167402 - Mark nsPresContext::mLinkHandler as MOZ_NON_OWNING_REF

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8932c66cf77

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make nsPresContext::mLinkHandler a smart pointer

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could you explain what steps you took to convince yourself that this patch won't introduce new leaks?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

In retrospect, this should have been a MOZ_NON_OWNING_REF. Thanks for making me look closer at it :).

I'll push an updated patch.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make nsPresContext::mLinkHandler a smart pointer

new try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f959d0c98aa

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8612320 [details] [diff] [review]
Make nsPresContext::mLinkHandler a smart pointer

Please fix the commit message and the bug summary to reflect that
you're now marking it MOZ_NON_OWNING_REF.

r=dbaron

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark nsPresContext::mLinkHandler as MOZ_NON_OWNING_REF

Oops commit message

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9052882b9330

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9052882b9330