AccessorShape is not a layout / trace kind

RESOLVED FIXED in Firefox 41

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8609064 [details] [diff] [review]
remove_accessorshape_layout-v0.diff

I'm not sure how I missed this before, but AccessorShape is a refinement AllocKind, like OBJECT4, than it is a TraceKind in its own right. It's not even in JSGCTraceKind and we don't actually use its inclusion in our list anywhere. We can remove it and it affects nothing.
Attachment #8609064 - Flags: review?(jcoppeard)
Comment on attachment 8609064 [details] [diff] [review]
remove_accessorshape_layout-v0.diff

Review of attachment 8609064 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Shouldn't AccessorShape be part of the FOR_EACH_GC_POINTER_TYPE list in Marking.cpp though?
Attachment #8609064 - Flags: review?(jcoppeard) → review+
(Assignee)

Comment 2

3 years ago
Good call! In practice we always mark these as Shape*, so it happens not to matter at the moment, but it certainly will if we ever use this list for more things.
https://hg.mozilla.org/mozilla-central/rev/4500dff8b55b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.