Incrementalize weak marking phase
Categories
(Core :: JavaScript: GC, defect)
Tracking
()
Performance Impact | medium |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 2 open bugs)
Details
(Keywords: perf)
Attachments
(23 files, 25 obsolete files)
72.50 KB,
patch
|
decoder
:
feedback-
gkw
:
feedback-
|
Details | Diff | Splinter Review |
2.62 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
4.51 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
6.53 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
21.83 KB,
patch
|
Details | Diff | Splinter Review | |
10.13 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
8.90 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
40.80 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 8•8 years ago
|
||
Assignee | ||
Comment 9•8 years ago
|
||
Assignee | ||
Comment 10•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 11•8 years ago
|
||
Assignee | ||
Comment 12•8 years ago
|
||
Assignee | ||
Comment 13•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Comment 16•7 years ago
|
||
Updated•7 years ago
|
Comment 17•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Comment 18•7 years ago
|
||
Assignee | ||
Comment 19•7 years ago
|
||
Assignee | ||
Comment 20•7 years ago
|
||
Assignee | ||
Comment 21•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 22•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 23•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 24•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 25•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 26•7 years ago
|
||
Assignee | ||
Comment 27•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 28•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 29•7 years ago
|
||
Assignee | ||
Comment 30•7 years ago
|
||
![]() |
||
Updated•7 years ago
|
Assignee | ||
Comment 33•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 34•7 years ago
|
||
Assignee | ||
Comment 35•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 36•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 37•7 years ago
|
||
Assignee | ||
Comment 38•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 39•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 40•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 41•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Comment 42•7 years ago
|
||
Updated•7 years ago
|
Comment 43•7 years ago
|
||
Comment 44•7 years ago
|
||
Comment 45•7 years ago
|
||
Updated•7 years ago
|
Comment 46•7 years ago
|
||
Comment 47•7 years ago
|
||
Comment 48•7 years ago
|
||
Comment 49•7 years ago
|
||
Updated•7 years ago
|
Comment 50•6 years ago
|
||
Comment 51•6 years ago
|
||
bugherder |
Assignee | ||
Comment 52•6 years ago
|
||
Assignee | ||
Comment 53•6 years ago
|
||
Depends on D31951
Assignee | ||
Comment 54•6 years ago
|
||
Depends on D31952
Assignee | ||
Comment 55•6 years ago
|
||
Depends on D31953
Assignee | ||
Comment 56•6 years ago
|
||
Depends on D31954
Assignee | ||
Comment 57•6 years ago
|
||
Depends on D31955
Assignee | ||
Comment 58•6 years ago
|
||
Depends on D31956
Assignee | ||
Comment 59•6 years ago
|
||
Depends on D31957
Assignee | ||
Comment 60•6 years ago
|
||
Depends on D31958
Assignee | ||
Comment 61•6 years ago
|
||
Depends on D31959
Assignee | ||
Comment 62•6 years ago
|
||
Comment 63•6 years ago
|
||
Comment 64•6 years ago
|
||
Backed out 7 changesets (bug 1167452) for spidermonkey bustages on weak-marking-02.js.
Backout: https://hg.mozilla.org/integration/autoland/rev/c452cbbba791fabe660a39d8cf22a200ddb107ff
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=249040643&revision=196e318992aa867869ab3de7cea0ae1365320cc3
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249040643&repo=autoland&lineNumber=22453
Assignee | ||
Comment 65•6 years ago
|
||
Oops, I guess I never tested opt builds. Sorry about that.
Updated•6 years ago
|
Comment 66•6 years ago
|
||
Comment 67•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b7c3cf320526
https://hg.mozilla.org/mozilla-central/rev/2202a5363839
https://hg.mozilla.org/mozilla-central/rev/a4f9778eec68
https://hg.mozilla.org/mozilla-central/rev/ab159f8b9041
https://hg.mozilla.org/mozilla-central/rev/617df479fac1
https://hg.mozilla.org/mozilla-central/rev/83677df08b08
https://hg.mozilla.org/mozilla-central/rev/d5c768b50d69
Updated•6 years ago
|
Comment 68•6 years ago
|
||
Comment 69•6 years ago
|
||
bugherder |
Comment 70•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 71•6 years ago
|
||
bugherder |
![]() |
||
Comment 72•6 years ago
|
||
Last changeset got backed. More information about the backout in bug 1514421.
Assignee | ||
Comment 73•6 years ago
|
||
Thank you sheriffs for the surgical backouts. After all the carnage, there are 3 regressions that I'll need to deal with to re-land:
bug 1514421 - this is the big one, it's a correctness problem that shows up as an uncommon (but not rare) intermittent. I fixed one incarnation of it shortly before landing. Apparently there's another.
bug 1556706 - smallish memory regression. This is still in the tree. It's from https://phabricator.services.mozilla.com/D31955 and I hope to fix or at least minimize it by playing with numbers.
bug 1557701 - performance regression. I was kind of hoping this would have the opposite effect, so I'll have to look at what's going on.
Assignee | ||
Comment 74•6 years ago
|
||
Oops, make that 4 regressions. I didn't notice this last one. It would be nice if the tree graph treated regressions as if they were either blocking or depending.
bug 1556329 - correctness problem. But it's caught in a fuzz bug, so life is good.
Comment 75•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 76•5 years ago
|
||
Comment 77•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 78•5 years ago
|
||
bugherder |
Assignee | ||
Comment 79•5 years ago
|
||
Assignee | ||
Comment 80•5 years ago
|
||
Assignee | ||
Comment 81•5 years ago
|
||
Assignee | ||
Comment 82•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 83•5 years ago
|
||
Assignee | ||
Comment 84•5 years ago
|
||
Comment 85•5 years ago
|
||
Comment 86•5 years ago
|
||
bugherder |
Assignee | ||
Comment 87•5 years ago
|
||
Resolving bug, actual activation happening in bug 1633176.
Assignee | ||
Comment 88•5 years ago
|
||
Comment 89•5 years ago
|
||
![]() |
||
Comment 90•5 years ago
|
||
Backout merged: https://hg.mozilla.org/mozilla-central/rev/91ec9a272383
Comment 91•5 years ago
|
||
This looks like a great achievement! I've added a note to the developer release notes at https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/78#JavaScript. Let me know if it captures this well.
Assignee | ||
Comment 92•5 years ago
|
||
(In reply to Florian Scholz [:fscholz] (MDN) from comment #91)
This looks like a great achievement! I've added a note to the developer release notes at https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/78#JavaScript. Let me know if it captures this well.
It sounds just right to me. Thank you!
Updated•3 years ago
|
Description
•