116748 - pref doesn't affect anything: scripts and windows - change status bar text

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect)

Description

[Jeremy M. Dolan]

I unchecked "change status bar text", however this page still updates my status
bar. Perhaps this is an old API that the pref doesn't block yet?

window.defaultStatus=text[pos];

Attaching page (as I had it saved, don't know the URL)

Comment 1

[Jeremy M. Dolan]

Attachment: page that changes the status bar

Comment 2

[Matthias Versen [:Matti]]

-> Security:CAPS

Comment 3

[Boris Zbarsky [:bzbarsky]]

Over to Doron.  The pref blocks access to window.status, not 
window.defaultStatus.  It should block both, I guess.

Comment 4

[Jeremy M. Dolan]

Dunno if I'm supposed to assign this to myself, or put [PATCH] in the summary or
whiteboard, or whatever, but I added defaultStatus to the objects that pref
blocked. Works perfect. Incoming patch.

Comment 5

[Jeremy M. Dolan]

Attachment: fix - add defaultStatus object

Comment 6

[Jeremy M. Dolan]

Asa tells me I'm supposed to reassign to myself if I have a fix. Need reviews.

Comment 7

[Jeremy M. Dolan]

Attachment: unbitroted fix

Yesterdays check-in reindented the file and parts of the patch wouldn't apply.

Can I get some reviews before it bitrots again?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 63165 [details] [diff] [review]
unbitroted fix

> -  var data = parent.hPrefWindow.wsm.dataManager.pageData["chrome://communicator/content/pref/pref-scripts.xul"];   
> +  var data = parent.hPrefWindow.wsm.dataManager.pageData["chrome://communicator/content/pref/pref-scripts.xul"];

> -  }  
> +  }

I hope those are not tabs you added to the file.  If they are, please fix that.

r=bzbarsky with that caveat

Comment 9

[Jeremy M. Dolan]

> I hope those are not tabs you added

Nope, I *removed* excessive spaces before EOL. (you can highlight the line with
your mouse in Moz to show the whitespace).

Shiny penny for the first to sr!

Comment 10

[Jeremy M. Dolan]

Attachment: more descriptive var names, requested by jag

Comment 11

[jag (Peter Annema)]

Comment on attachment 63226 [details] [diff] [review]
more descriptive var names, requested by jag

Lifting over r=, adding sr=jag

Comment 12

[Jeremy M. Dolan]

Checked in - thanks jag.

Comment 13

[bsharma]

Verified on 2002-01-29-03 build on WinNT.

When I load the attachment (id=62695), the status bar still gets updated. Please
let me know if I am doing/verifying something wrong.

Keeping this bug open.

Comment 14

[Mitchell Stoltz (not reading bugmail)]

Bindu,
   You need to go to Preferences: Scripts and WIndows and uncheck the box next
to "change status bar text" before running the test. Did you do that?

Comment 15

[bsharma]

After unchecking the preference the test case works fine.

Comment 16

[bsharma]

Marking it verified now.