Closed
Bug 1167502
Opened 9 years ago
Closed 9 years ago
Use TabStateFlusher.flush() instead of sync flushing in tests
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(3 files)
|
1.71 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
|
2.23 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
|
56.70 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
We can get rid of synchronous TabState.flush() calls in tests.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8609194 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8609195 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Use TabStateFlusher in tests where possible → Use TabStateFlusher.flush() instead of sync flushing in tests
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8609196 -
Flags: review?(wmccloskey)
Attachment #8609194 -
Flags: review?(wmccloskey) → review+
Attachment #8609195 -
Flags: review?(wmccloskey) → review+
Attachment #8609196 -
Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/integration/fx-team/rev/d370d22aacd5 https://hg.mozilla.org/integration/fx-team/rev/bf3ebcb6f305 https://hg.mozilla.org/integration/fx-team/rev/92a7d9f78623
|
|
Assignee | |
Comment 6•9 years ago
|
||
Had to push a bustage fix because I somehow forgot to actually import the new JSM. I am sure though I ran the tests locally... whatever.
|
||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d370d22aacd5 https://hg.mozilla.org/mozilla-central/rev/bf3ebcb6f305 https://hg.mozilla.org/mozilla-central/rev/92a7d9f78623 https://hg.mozilla.org/mozilla-central/rev/0650d41cd3de https://hg.mozilla.org/mozilla-central/rev/b2846368c764
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•