1167503 - Remove |popPermissions| in dom/apps/tests/test_third_party_homescreen.html

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Junior [inactive]]

After Bug 1149868 lands, we need not to use |popPermissions| as a workaround in the test dom/apps/tests/test_third_party_homescreen.html. Just simply remove this two-lines chunk.

https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_third_party_homescreen.html#178

Comment 1

[mootoh]

Attachment: 1167503.diff

Here is a quick patch for this, which looks too obvious though.

Comment 2

[Junior [inactive]]

Since Bug 1149868 has landed, here's something you could do next:
1. Take this bug
2. Rebase and test again to make sure your patch work (locally test and/or push to try server)
3. Request a review to a module owner

Enjoy!

Comment 3

[mootoh]

Thanks :junior and :glob, I asked a commit access Level 1 in Bug 1168288 to test it on try server.

Comment 4

[mootoh]

Tested the change on try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5002ae21d4bc

It looks like it failed in browser/base/content/test/general/browser_popup_blocker.js, though I guess it is not related to this change.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8610094 [details] [diff] [review]
1167503.diff

Review of attachment 8610094 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I re-triggered bc1 and it's green.

Comment 6

[mootoh]

Thanks Fabrice for the review.
Now I think the steps :junior mentioned have been completed. What else I can do to land this?

Comment 7

[[:fabrice] Fabrice Desré]

(In reply to mootoh from comment #6)
> Thanks Fabrice for the review.
> Now I think the steps :junior mentioned have been completed. What else I can
> do to land this?

You need to update your patch commit message to add r=fabrice, then you can set `checkin-needed` in the keyword field of the bug. Thanks for contributing!

Comment 8

[Junior [inactive]]

Hello mootoh, 
If you need some information from somebody, you could use needinfo flag.
Happy hacking!

Comment 9

[mootoh]

Attachment: 1167503-2nd.patch

Updated the commit message of the patch to include the reviewer.

Comment 10

[mootoh]

Thanks Fabrice, the patch has been updated and I've just set the keyword as `checkin-needed`.
Alright Junior, good to know that and I'll do it next.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6ccc2b40fd

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf6ccc2b40fd

Comment 13

[Junior [inactive]]

congrat!

Comment 14

[mootoh]

Thanks everyone helping me! Now I'm going to search another ones.