1167507 - [B2G][FDN] Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

[Tracking Requested - why for this release]:

In bug 1114937 comment 3, we would like to ensure the data type of the input contact to MozIcc is formed in mozContact.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch: Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact.

This is to have explicit data type 'mozContact' in MozIcc.updateContact() instead of 'any'.
After review the implementation in Gaia, there are 2 modules infected
1. Contacts App for the ADN contacts in UICC.
2. Settings App for the FDN contacts in UICC.
However Contacts App already apply mozContact as the input of MozIcc.updateContact().
What we have to do is to have FDN contacts wrapped with mozContact.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8628695 [details] [review]
Patch: Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact.

Hi José,

As mentioned in bug 1114937 comment 3, we'd like to have explicit data type of the input in MozIcc.updateContact().
Hence, in bug 1114937, we'd like to change the data type of the contact from <any> to <mozContact>.

After reviewing the implementation in Gaia, I found that only FDN is not wrapped with mozContact as the input of updateContact().

Hence, may I have your review of the change in FDN?

Thanks!

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8628695 [details] [review]
Patch: Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact.

Hi Evelyn,

Unfortunately, I can't get any response from Jose for this review. :(

May I have your review for this change instead?

Thanks!

--

This change is to fix the issue mentioned in bug 1114937 comment 3.
We'd like to ensure that all the contact going through Icc Contacts are type of mozContact instead of <any>.
(All the layout of these contacts are actually aligned with the structure of mozContact even though <any> was defined in the webidl[1].)

After reviewing the implementation in Gaia, I found that only FDN is not wrapped with mozContact as the input of updateContact().

[1] https://dxr.mozilla.org/mozilla-central/source/dom/webidl/MozIcc.webidl#335-337

Comment 4

[Evelyn Hung]

Comment on attachment 8628695 [details] [review]
Patch: Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact.

Thanks for patching Gaia!

Comment 5

[Evelyn Hung]

master: https://github.com/mozilla-b2g/gaia/commit/d8e68a7f53683a13b432d6166d00d89de9d1e3b8