1167528 - Firefox can't play a MP4 video when its moov box is at the end of file

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect)

Description

[Blake Wu [:bwu][:blakewu]]

Device:
Flame 

SW version:
3.0 code base (two days again). 

Repro step: 
1. Push the test video to phone. 
2. Open Video APP. 

Expected result:
The thumbnail of the test file will be shown. 

Actual result:
The running dot-line (means it is generating thumbnail) on the top of screen will not stop. The thumbnail is not shown.

Repro rate: 
100%

Comment 1

[Blake Wu [:bwu][:blakewu]]

Attachment: 540x960_cosmote_mp4_15fps_start.mp4

The test video file.

Comment 2

[Blake Wu [:bwu][:blakewu]]

After a quick check, Gecko fails to read MetaData and return false @MP4Demuxer::Init()[1] 

[1]https://dxr.mozilla.org/mozilla-central/source/dom/media/fmp4/MP4Demuxer.cpp?from=MP4Demuxer.cpp&case=true#35

Comment 3

[Blake Wu [:bwu][:blakewu]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #0)
> Device:
> Flame 
> 
> SW version:
> 3.0 code base (two days again). 
Need to also apply the patch, attachment 8609133 [details] [diff] [review], in bug 1166169 to let video play with PDM and new demuxer.

Comment 4

[Alfredo Yang (:alfredo)]

Not only gonk but other platforms have the same problem. The moov is at the end of video and demux can't find it when reading metadata.

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: fix_large_box_length

The video can be played after applied this patch; however, it displays error the end.
This video has unknown box, I guess our demuxer doesn't recognize it.

Comment 6

[Alfredo Yang (:alfredo)]

Gonk is ok after applying demux patch. It could be problem of Mac PlatformDecoderModule.

Comment 7

[Alfredo Yang (:alfredo)]

Attachment: fix_large_box_length

I'll add a test case later.

Comment 8

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8613424 [details] [diff] [review]
fix_large_box_length

Review of attachment 8613424 [details] [diff] [review]:
-----------------------------------------------------------------

A mochitest for this case would probably help us avoid breaking this again.