Closed Bug 1167590 Opened 5 years ago Closed 5 years ago

Mark imgRequestProxy::mListener as MOZ_UNSAFE_REF

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 2 obsolete files)

No description provided.
Blocks: 1114683
Whiteboard: [gfx-noted]
Attachment #8609364 - Flags: review?(netzen)
Comment on attachment 8609364 [details] [diff] [review]
Mark imgRequestProxy::mListener as MOZ_UNSAFE_REF

Seth would probably be a better reviewer for imagelib things.
Attachment #8609364 - Flags: review?(netzen) → review?(seth)
Assignee: nobody → michael
Comment on attachment 8609364 [details] [diff] [review]
Mark imgRequestProxy::mListener as MOZ_UNSAFE_REF

Review of attachment 8609364 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the slow review; I've been unavailable to varying degrees for the past two weeks.

::: image/src/imgRequestProxy.h
@@ +203,5 @@
>  
>    // mListener is only promised to be a weak ref (see imgILoader.idl),
>    // but we actually keep a strong ref to it until we've seen our
>    // first OnStopRequest.
> +  imgINotificationObserver* MOZ_UNSAFE_REF("Callers of methods setting mListener "

I'm not sure that "Callers of methods setting mListener" is quite the right way to phrase this. Just say something like "Observers must call Cancel() or CancelAndForgetObserver() before they are destroyed."
Attachment #8609364 - Flags: review?(seth) → review+
No problem. Updated patch with changed phrasing.
Attachment #8609364 - Attachment is obsolete: true
Keywords: checkin-needed
Hi,

this failed to apply:
applying Bug-1167590---Mark-imgRequestProxymListener-as-MOZ.patch
unable to find 'image/src/imgRequestProxy.h' for patching
1 out of 1 hunks FAILED -- saving rejects to file image/src/imgRequestProxy.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1167590---Mark-imgRequestProxymListener-as-MOZ.patch
Flags: needinfo?(michael)
Keywords: checkin-needed
Should apply cleanly on mozilla-central now.
Attachment #8621690 - Attachment is obsolete: true
Flags: needinfo?(michael)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1f62853f6c43
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.