1167689 - Omit the "addonHistograms" key entirely if there is no histogram data

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Mark Reid [:mreid]]

Telemetry currently reports "addonHistogram":{} when there is nothing to report.  We should just skip that key if there's no data.

Comment 1

[Anthony Zhang [:azhang] (last day at Mozilla: 2016-04-29)]

Attachment: optional-addon-histograms.patch

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 8610245 [details] [diff] [review]
optional-addon-histograms.patch

Review of attachment 8610245 [details] [diff] [review]:
-----------------------------------------------------------------

Do an "hg export" before you upload patches so that your author information, commit comments, etc is in the patch. Then the patch file can be landed directly from the bug by setting the checkin-needed tag on the bug's Whiteboard field

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1379,5 @@
>        payloadObj.lateWrites = Telemetry.lateWrites;
> +
> +      // Add the addon histograms if they are present
> +      let addonHistograms = this.getAddonHistograms();
> +      for (let name in addonHistograms) {

this is a bit hacky.. how about:

if (Object.keys(addonHistograms).length) {
  payloadObj.addonHistograms = addonHistograms;
}

Comment 3

[Anthony Zhang [:azhang] (last day at Mozilla: 2016-04-29)]

Attachment: optional-addon-histograms.patch

Comment 4

[Vladan Djeric (:vladan)]

Oh and usually you'll need to add r=<reviewer's irc nick> to the end of your commit message

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/63f60689f769

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63f60689f769