1167700 - Polycraft Demo does not play since Firefox 38

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect)

Description

[Todd Brais]

Attachment: fx40_Lothar_dxdiag.txt

Actual Result:
When the user selects to 'Play' the Polycraft Demo; the game does not load; instead the user receives an infinite loading loop; where the splash screen will reload
Note: Game loads fine when using google chrome

Expected Result:
Game loads on FF 40 without any issues

Steps to Reproduce:
1. With e10s enabled OR disabled; launch the 'Polycraft' demo
https://ga.me/games/polycraft

2. Click the 'Play' button, and observe that demo does not load

Comment 1

[Todd Brais]

Attachment: fx40_Lothar_support.txt

Comment 2

[Alice0775 White]

An error shown in Error console:

Error: TypeError: d.setData is not a function
Source File: https://d36kx37nk0bz9z.cloudfront.net/UL8x6Zt1aIlmd5Pg/S/XekgIicoqMGQnWhZXf65DV6awFI1m49A-HHijpA7-Y310b99.js
Line: 849

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0aa5dec4bf2a&tochange=5f26a8bdf93e

Triggered by:Bug 1121936, Bug 1121935

Comment 3

[u279076]

Tom, do you have any thoughts on this regression?

Comment 4

[u279076]

[Tracking Requested - why for this release]: this is a regression which puts us at a competitive disadvantage.

Comment 5

[Tom S [:evilpie]]

It's a site bug. ma.prototype.createTechniqueParameterBuffer has this code:

void 0 === Float32Array.prototype.map && (Float32Array.prototype.map = function (a, c) {
....
}
}
}, Float32Array.prototype.unmap = function () {
}, Float32Array.prototype.setData = function (a, c, d) {
...
});

Which basically means when the function Float32Array.prototype.map exists, this other function "setData" isn't even added to the prototype.

Comment 6

[u279076]

Is there something we can do to improve the situation here since it works fine in Chrome? or is this a straight up tech evangelism bug which we cannot fix?

Comment 7

[Tom S [:evilpie]]

We can backout the change, but it's a function defined in the ES6 standard, so I would rather not do that. We should try evangelism first.

Comment 8

[u279076]

Moving over to Tech Evangelism based on comment 7.

Martin, do you know if the Games team has any contact with the developer of this site?

Comment 9

[Mike Taylor [:miketaylr]]

It looks like the code from Comment 5 is actually part of the turbulenz_engine. So there are potentially lots more sites that will be affected. :/

<https://github.com/turbulenz/turbulenz_engine/blob/8f9ffd245fb05782352db959be0a979bbb7b6f1b/tslib/webgl/graphicsdevice.ts#L4916>

Comment 10

[Mike Taylor [:miketaylr]]

I see that Microsoft already reported an issue: https://github.com/turbulenz/turbulenz_engine/issues/43

Comment 11

[Martin Best (:mbest)]

Hey.  I can reach out to the CEO over at Turbulenz.

Comment 12

[Martin Best (:mbest)]

Sent an email explaining the situation with a link to this bug.

Comment 13

[u279076]

Thank you Mike and Martin.

Comment 14

[Martin Best (:mbest)]

Turbulenz wrote back:

"Thank you - we are aware of the issue.

(Whilst the fix is simple, the deployment isn't - as we need to rebuild and redeploy all the games to include this fix.)"

Comment 15

[ssimon]

Also occurs on Onyxia.  Included DxDiag.

Comment 16

[ssimon]

Attachment: ff40_onyxia_DxDiag.txt

Comment 17

[u279076]

Thanks for closing the loop, Martin. Is there anything we can do to work around this issue or do we simply have to live with it?

Comment 18

[Sylvestre Ledru [:Sylvestre]]

[Tracking Requested - why for this release]:
Too late for 38. Request tracking for 39 to make sure Liz sees it.

Comment 19

[Martin Best (:mbest)]

I'll ping again to figure out status.

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds like Martin and Turbulenz are handling this. Let's hope it's fixed before 39 goes to release at the end of June.

Comment 21

[Martin Best (:mbest)]

They let me know it is something they are working towards.  They don't have an ETA.  They have a resolution however.  They are working to distribute the fixes to places it's deployed which is the challenge.

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

Wontfix for 39. If this has been fixed by Polycraft then please update us. Thanks!

Comment 23

[Sylvestre Ledru [:Sylvestre]]

Not tracking anymore. It seems that it is not really our fault. So, not point still tracking it.

Comment 24

[Trammel May]

Attachment: OnyxiaOhNuts.bmp

Bug not fixed, however now it thinks the browser is out of date.

Comment 25

[Trammel May]

Note: Browser 43 was used to replicate.

Comment 26

[u279076]

Martin, any update from the developer given comment 24?

Comment 27

[Trammel May]

Attachment: OnyxiaOhNuts.bmp.tar.gz

compressed version

Comment 28

[Trammel May]

Attachment: OnyxiaUntrusted.bmp.tar.gz

Comment 29

[Trammel May]

(In reply to Trammel May from comment #28)
> Created attachment 8680175 [details]
> OnyxiaUntrusted.bmp.tar.gz

disregard this file, it was from not from the regression test, but the original v43 test plan.

Comment 30

[Martin Best (:mbest)]

Not seeing any reaction from the developer.  They are aware of the problem and know what to do about it but we have not seen them take any action.  My sense is they are no longer pursuing the web as a primary target and are currently focused on console and native game releases so they are not putting resources behind a solution.

Comment 31

[Martin Best (:mbest)]

I've added Andre to this bug who is now the Product person looking at games.  Turbulenz is the developer.

Comment 32

[Martin Best (:mbest)]

Just tested this to insure it's not working and I was able to get in in FF42 and play the game.  Can someone double check?

Comment 33

[u279076]

(In reply to Martin Best (:mbest) from comment #32)
> Just tested this to insure it's not working and I was able to get in in FF42
> and play the game.  Can someone double check?

Can you check Firefox 43? That's what Trammel used to test several days ago in comment 25.

Comment 34

[Martin Best (:mbest)]

Tested it in nightly (45) and no issue there.  Just getting beta.

Comment 35

[Martin Best (:mbest)]

just tested in 43, no issue.  The load bar sits for a bit but then goes through.

Comment 36

[u279076]

This bug was originally reported against the following systems:
* Lothar: Windows 7 32-bit with a NVIDIA GeForce 7300LE 256MB 
* Onyxia: Windows XP with dual NVIDIA GeForce 7950 GT 512MB in SLI

Hardware and/or platform may be a factor in reproducing this. Martin, what system are you running this on?

Comment 37

[Trammel May]

I just regressed this and it played fine. 

I am wondering if the original test didn't allow the browser enough time to load the game, as it did take about a minute. 

QA Confirmed: Fixed

Comment 38

[u279076]

Thanks, that seems to confirm what Martin reported earlier. I'm resolving this bug as WORKSFORME - please reopen if you have steps to reproduce in a current Firefox build.