Closed Bug 1167708 Opened 9 years ago Closed 9 years ago

[Customizer] Initialization fails if injecting into an already-loaded app

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Customizer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

pull-request (master)
42 bytes, text/x-github-pull-request
drs
: review+
Details | Review 
If you enable Customizer, any apps that were already running at the time you enabled it will not be properly initialized. This is because Customizer waits for DOMContentLoaded. We need to check if the DOM appears to already be ready and if so, initialize immediately.
Assignee: nobody → jdarcangelo
Blocks: spark-customizer
Priority: -- → P1
Whiteboard: [spark]
Attached file pull-request (master) — 

        Attachment #8610738 -
        Flags: review?(drs)

    
    

    
  
Comment on attachment 8610738 [details] [review]
pull-request (master)

Looks good. I left one comment on the PR that should be addressed before landing.

        Attachment #8610738 -
        Flags: review?(drs) → review+

    
    

    
  
Addressed comment on PR.

Landed on master:

https://github.com/fxos/customizer/commit/4ca4c69c71ab2e555dba25990a3e8e16b0a7c3e2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: