Closed
Bug 1167805
Opened 9 years ago
Closed 9 years ago
Not enough padding for page title causing pin icon to overlap
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: soeren.hentzschel, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: .?)
Attachments
(6 files)
221.64 KB,
image/png
|
Details | |
5.06 KB,
image/png
|
Details | |
11.36 KB,
image/png
|
Details | |
1.32 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
1.33 KB,
patch
|
Details | Diff | Splinter Review | |
1.33 KB,
patch
|
Details | Diff | Splinter Review |
The attached screenshot shows a style bug introduced with the last design changes on about:newtab.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1158853 shifted in the pin icon by some pixels.
Assignee | ||
Comment 2•9 years ago
|
||
dcrobot, enclosing the title is shaving off some space available for titles. But this should only be an issue for pinned tiles that can have custom titles or tiles with titles that come from our servers.
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Iteration: --- → 41.1 - May 25
Points: --- → 2
Updated•9 years ago
|
Attachment #8609697 -
Flags: review?(adw) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ce1600174c15
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
verified on 41.0a1 (2015-05-26) verification steps: 1. do multiple loads of http://economyclassandbeyond.boardingarea.com 2. get economyclassandbeyond.boardingarea.com to show up in newtab 3. pin the the tile 4. the pin icon does not obstruct the subdomain string (the subdomain string moves to the right)
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to maxim zhilyaev from comment #10) > 1. do multiple loads of http://economyclassandbeyond.boardingarea.com Ha! Nice find of a long subdomain. :)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8610031 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610031 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 13•9 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/06ba020c6f0f
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8610031 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610031 -
Flags: approval-mozilla-aurora?
Comment 15•9 years ago
|
||
Verified fixed on latest Aurora, build ID: 20150528004000. Tested on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.
You need to log in
before you can comment on or make changes to this bug.
Description
•