Not enough padding for page title causing pin icon to overlap

VERIFIED FIXED in Firefox 40

Status

()

VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: soeren.hentzschel, Assigned: Mardak)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 41
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox40 verified, firefox41 verified)

Details

(Whiteboard: .?)

Attachments

(6 attachments)

(Reporter)

Description

4 years ago
Created attachment 8609683 [details]
screenshot.png

The attached screenshot shows a style bug introduced with the last design changes on about:newtab.
(Assignee)

Comment 1

4 years ago
Bug 1158853 shifted in the pin icon by some pixels.
Blocks: 1158853
No longer blocks: 1150228
Summary: New Tab Page: Pin icon / page title overlap → Not enough padding for page title causing pin icon to overlap
Whiteboard: .?
(Assignee)

Comment 2

4 years ago
dcrobot, enclosing the title is shaving off some space available for titles. But this should only be an issue for pinned tiles that can have custom titles or tiles with titles that come from our servers.
(Assignee)

Comment 3

4 years ago
Created attachment 8609692 [details]
screenshot with pin and without pin
(Assignee)

Comment 4

4 years ago
Created attachment 8609696 [details]
v1 screenshot
(Assignee)

Comment 5

4 years ago
Created attachment 8609697 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8609697 - Flags: review?(adw)
(Assignee)

Updated

4 years ago
Iteration: --- → 41.1 - May 25
Points: --- → 2

Updated

4 years ago
Attachment #8609697 - Flags: review?(adw) → review+
(Assignee)

Updated

4 years ago
Blocks: 1140185
https://hg.mozilla.org/mozilla-central/rev/ce1600174c15
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Assignee)

Comment 8

4 years ago
Created attachment 8610031 [details] [diff] [review]
for aurora (Mardak will land)
(Assignee)

Comment 9

3 years ago
Created attachment 8610419 [details] [diff] [review]
for beta (Mardak will land)

Comment 10

3 years ago
verified on 41.0a1 (2015-05-26)

verification steps:

1. do multiple loads of http://economyclassandbeyond.boardingarea.com
2. get economyclassandbeyond.boardingarea.com to show up in newtab
3. pin the the tile
4. the pin icon does not obstruct the subdomain string (the subdomain string moves to the right)
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
(Assignee)

Comment 11

3 years ago
(In reply to maxim zhilyaev from comment #10)
> 1. do multiple loads of http://economyclassandbeyond.boardingarea.com
Ha! Nice find of a long subdomain. :)
(Assignee)

Comment 12

3 years ago
Comment on attachment 8610031 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment: See bug 1140185 comment 11
Attachment #8610031 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 13

3 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/06ba020c6f0f
status-firefox40: --- → fixed
Flags: qe-verify+
Flags: firefox-backlog+
(Assignee)

Comment 14

3 years ago
Comment on attachment 8610031 [details] [diff] [review]
for aurora (Mardak will land)

approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610031 - Flags: approval-mozilla-aurora?
Verified fixed on latest Aurora, build ID: 20150528004000.

Tested on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.