Closed Bug 1167805 Opened 10 years ago Closed 10 years ago

Not enough padding for page title causing pin icon to overlap

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: soeren.hentzschel, Assigned: Mardak)

References

Details

(Whiteboard: .?)

Attachments

(6 files)

screenshot.png
221.64 KB, image/png
Details
screenshot with pin and without pin
5.06 KB, image/png
Details
v1 screenshot
11.36 KB, image/png
Details
v1
1.32 KB, patch
adw
: review+
Details | Diff | Splinter Review
for aurora (Mardak will land)
1.33 KB, patch
Details | Diff | Splinter Review
for beta (Mardak will land)
1.33 KB, patch
Details | Diff | Splinter Review
Attached image screenshot.png —
The attached screenshot shows a style bug introduced with the last design changes on about:newtab.
Bug 1158853 shifted in the pin icon by some pixels.
Blocks: 1158853
No longer blocks: 1150228
Summary: New Tab Page: Pin icon / page title overlap → Not enough padding for page title causing pin icon to overlap
Whiteboard: .?
dcrobot, enclosing the title is shaving off some space available for titles. But this should only be an issue for pinned tiles that can have custom titles or tiles with titles that come from our servers.
Attached image v1 screenshot —
Attached patch v1 — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8609697 - Flags: review?(adw)
Iteration: --- → 41.1 - May 25
Points: --- → 2
Attachment #8609697 - Flags: review?(adw) → review+
Blocks: 1140185
https://hg.mozilla.org/mozilla-central/rev/ce1600174c15
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
verified on 41.0a1 (2015-05-26) verification steps: 1. do multiple loads of http://economyclassandbeyond.boardingarea.com 2. get economyclassandbeyond.boardingarea.com to show up in newtab 3. pin the the tile 4. the pin icon does not obstruct the subdomain string (the subdomain string moves to the right)
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
(In reply to maxim zhilyaev from comment #10) > 1. do multiple loads of http://economyclassandbeyond.boardingarea.com Ha! Nice find of a long subdomain. :)
Comment on attachment 8610031 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610031 - Flags: approval-mozilla-aurora?
http://hg.mozilla.org/releases/mozilla-aurora/rev/06ba020c6f0f
status-firefox40: --- → fixed
Flags: qe-verify+
Flags: firefox-backlog+
Comment on attachment 8610031 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610031 - Flags: approval-mozilla-aurora?
Verified fixed on latest Aurora, build ID: 20150528004000. Tested on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: