1167834 - widget/cocoa/nsCocoaDebugUtils.mm:151:21 [-Wwritable-strings] ISO C++11 does not allow conversion from string literal to 'char *'

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Wwritable-strings_nsCocoaDebugUtils.patch

clang warns about assigning string constant "unknown" to a non-const char pointer:

widget/cocoa/nsCocoaDebugUtils.mm:151:21 [-Wwritable-strings] ISO C++11 does not allow conversion from string literal to 'char *'
widget/cocoa/nsCocoaDebugUtils.mm:152:25 [-Wwritable-strings] ISO C++11 does not allow conversion from string literal to 'char *'

However, these string pointers can't be made const because (C++'s but not C's!) free() requires a non-const pointer parameter. This patch removes the stringsNeedRelease flag and saves the malloc'd strings, if any, in dedicated non-const pointers.

Comment 1

[Stephen A Pohl [:spohl]]

Comment on attachment 8609718 [details] [diff] [review]
Wwritable-strings_nsCocoaDebugUtils.patch

Forwarding review request to get faster turnaround on this during my PTO.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8609718 [details] [diff] [review]
Wwritable-strings_nsCocoaDebugUtils.patch

Looks fine to me.  Thanks for the fix.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b2ecf508e6

Comment 4

[Chris Peterson [:cpeterson]]

Thanks!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c7b2ecf508e6