1167942 - Replace ListView in search list with RecyclerView

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Bug 1133560 revealed a limitation of ListViews (Drawing dividers) in the search list on Lollipop and above. Switching from ListView to RecyclerView will give us more freedom about how the component will behave in different states. This has been planned in meta bug 1158303 anyways and this might be a good reason to start with this component.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Unassign: I still want to do this (working on other things right now) but I also don't want to block this.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Grabbing since I've started an implementation of this already for SearchEngineBar.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Jonathan Almeida [:jonalmeida] from comment #2)
> Grabbing since I've started an implementation of this already for
> SearchEngineBar.

Awesome! Do you have a bug for the search engine bar that we can attach to bug 1158303?

Comment 4

[Jonathan Almeida [:jonalmeida]]

> Awesome! Do you have a bug for the search engine bar that we can attach to bug 1158303?

Just made it and added it as a dependency. :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Jonathan Almeida [:jonalmeida] from comment #4)
> > Awesome! Do you have a bug for the search engine bar that we can attach to bug 1158303?
> 
> Just made it and added it as a dependency. :)

Cool, thank you! But I guess this one here does not depend on bug 1184211, or are they going to share some code?

Comment 6

[k.krish]

Can I investigate this bug and try to resolve it?

Comment 7

[Owais Kazi]

If nobody is working on it can i work on it as my first bug?

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

This is a rather big task for a first bug. How about bug 1336650 or bug 1350886 (This one requires changes to the build and is a bit tricky)?

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.