1168005 - [e10s] NS_QUERY_TEXT_RECT to content process doesn't return mString

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

It requires on Cocoa's implementation.

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: NS_QUERY_TEXT_RECT should set mString

Comment 2

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8610008 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

I forget this :-<.  NS_QUERY_TEXT_RECT should set mString.  It is used on Cocoa's widget.

Comment 3

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8610008 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

Oops, this is invalid patch

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: NS_QUERY_TEXT_RECT should set mString

Comment 5

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8610012 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

Cocoa widget uses mString parameter by NS_QUERY_TEXT_RECT.  But it isn't implemented on e10s yet.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Comment on attachment 8610012 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

>+                    (mIMECacheText.Length() > aEvent.mInput.mOffset +
>+                                              aEvent.mInput.mLength) ?
>+                      aEvent.mInput.mLength : UINT32_MAX);

nit:

(mIMECacheText.Length() >
   aEvent.mInput.mOffset + aEvent.mInput.mLength) ?
  aEvent.mInput.mLength : UINT32_MAX;

Looks nicer to me. But I guess, you implement EndOffset() to the mInput is smarter.

And also, shouldn't be |>=| ?

Comment 7

[Makoto Kato [:m_kato] (PTO until 5/6)]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) (working slowly due to bad health condition) from comment #6)

> And also, shouldn't be |>=| ?

greater than or equal is better rather than original.  but if equal condition, it is same result (

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/102b30c582cd

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/102b30c582cd