Closed Bug 1168005 Opened 5 years ago Closed 5 years ago

[e10s] NS_QUERY_TEXT_RECT to content process doesn't return mString

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m8+ ---
firefox41 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

It requires on Cocoa's implementation.
tracking-e10s: --- → ?
Assignee: nobody → m_kato
Comment on attachment 8610008 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

I forget this :-<.  NS_QUERY_TEXT_RECT should set mString.  It is used on Cocoa's widget.
Attachment #8610008 - Flags: review?(masayuki)
Comment on attachment 8610008 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

Oops, this is invalid patch
Attachment #8610008 - Flags: review?(masayuki)
Attachment #8610008 - Attachment is obsolete: true
Comment on attachment 8610012 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

Cocoa widget uses mString parameter by NS_QUERY_TEXT_RECT.  But it isn't implemented on e10s yet.
Attachment #8610012 - Flags: review?(masayuki)
Comment on attachment 8610012 [details] [diff] [review]
NS_QUERY_TEXT_RECT should set mString

>+                    (mIMECacheText.Length() > aEvent.mInput.mOffset +
>+                                              aEvent.mInput.mLength) ?
>+                      aEvent.mInput.mLength : UINT32_MAX);

nit:

(mIMECacheText.Length() >
   aEvent.mInput.mOffset + aEvent.mInput.mLength) ?
  aEvent.mInput.mLength : UINT32_MAX;

Looks nicer to me. But I guess, you implement EndOffset() to the mInput is smarter.

And also, shouldn't be |>=| ?
Attachment #8610012 - Flags: review?(masayuki) → review+
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) (working slowly due to bad health condition) from comment #6)

> And also, shouldn't be |>=| ?

greater than or equal is better rather than original.  but if equal condition, it is same result (
https://hg.mozilla.org/mozilla-central/rev/102b30c582cd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.