Closed Bug 1168075 Opened 4 years ago Closed 4 years ago

[bluetooth2] Build break on flame-kk after enabling bluetooth api v2.

Categories

(Core :: WebRTC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: brsun, Assigned: brsun)

Details

Attachments

(2 files, 1 obsolete file)

We encounter build breaks on flame-kk when building bluetooth2[1] using m-c.

It might be related to missing header files in |CanvasCaptureMediaStream.h|.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8606105
Hi Andreas,

I've tried this patch and it can make my flame-kk build success with bluetooth api v2. Do you think this modification make sense?
Attachment #8610073 - Flags: feedback?(pehrsons)
Comment on attachment 8610073 [details] [diff] [review]
bug1168075_canvas_capture_media_stream_build_fail.patch

Review of attachment 8610073 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, how did just enabling bluetooth2 break canvas streaming? They seem completely orthogonal to me.

::: dom/media/CanvasCaptureMediaStream.h
@@ +6,5 @@
>  #ifndef mozilla_dom_CanvasCaptureMediaStream_h_
>  #define mozilla_dom_CanvasCaptureMediaStream_h_
>  
> +#include "DOMMediaStream.h"
> +#include "StreamBuffer.h"

Is it possible to forward declare stuff here and do the includes in the .cpp?
Attachment #8610073 - Flags: feedback?(pehrsons)
Do you have build logs or similar, showing the errors you got, anywhere?
Flags: needinfo?(brsun)
Attached file build_fail.txt
Flags: needinfo?(brsun)
Comment on attachment 8610073 [details] [diff] [review]
bug1168075_canvas_capture_media_stream_build_fail.patch

Review of attachment 8610073 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I see. Include order has changed and at least some typedefs are needed from these headers. Yeah, seems like the right fix.
Attachment #8610073 - Flags: review+
Attachment #8610073 - Attachment is obsolete: true
Attachment #8610360 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/af26700a02ed
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.