1168136 - Add an option to prefer single-column or grid layout for tabs on iPhone

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Darrin Henein [:darrin]]

There should exist a preference in settings that lets users decide their tab screen layout. This should be trivial to implement using the collectionview layout. We also want to experiment with defaulting to Compact in Nightly for a few weeks.

Proposal
---

"Normal" or "Default": single column on iPhone, 3 columns on iPad
"Compact": 2 columns on iPhone, 4 columns on iPad

Assigning to :st3fan as we've talked briefly about this.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/508

This patch adds support for a 'Compact Tab Tray' preference that shows more tabs horizontally when enabled.

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8611341 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/508

Looks like on first launch it's using compactTabs although the settings menu shows that compactTabs is not selected. Should the toggle be on by default or are we defaulting to non-compact tabs?

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed the settings, it should default to on, and merged.

Comment 4

[Darrin Henein [:darrin]]

Let's go back to 3 cols on iPad. 4 is too small.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Followup PR: https://github.com/mozilla/firefox-ios/pull/542

This patch disabled compact tabs on iPad. It defaults to 3 columns and it does not show the Compact Tabs option in the settings.

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8614110 [details] [review]
Followup PR: https://github.com/mozilla/firefox-ios/pull/542

LGTM