Closed Bug 1168170 Opened 5 years ago Closed 4 years ago

Mark RefCount members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attachment #8610199 - Flags: review?(benjamin)
Blocks: 1114683
Attachment #8610199 - Flags: review?(benjamin) → review?(nfroyd)
Comment on attachment 8610199 [details] [diff] [review]
Mark RefCount members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Review of attachment 8610199 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but I'd suggest changing the commit message: "Mark RefCount members..." sounds like the members are of type |RefCount|, which is not the case.
Attachment #8610199 - Flags: review?(nfroyd) → review+
Fixed up commit message
Attachment #8610199 - Attachment is obsolete: true
Assignee: nobody → michael
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/894bf4c333e9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.