1168170 - Mark RefCount members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97d050105ff2

Comment 1

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Mark RefCount members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8610199 [details] [diff] [review]
Mark RefCount members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Review of attachment 8610199 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but I'd suggest changing the commit message: "Mark RefCount members..." sounds like the members are of type |RefCount|, which is not the case.

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Mark reference counted members of nsTimerImpl::mCallback as MOZ_OWNING_REF

Fixed up commit message

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/894bf4c333e9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/894bf4c333e9