Closed
Bug 1168193
Opened 9 years ago
Closed 9 years ago
Closing a tab with the 'x' should replicate the swipe animation to teach the user
Categories
(Firefox for iOS :: Theme & Visual Design, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: dhenein, Assigned: sleroux)
Details
(Whiteboard: noteworthy)
Attachments
(1 file)
To teach the user about the swipe-to-delete interaction, we should animate the tab sideways to hint at the gesture.
|
||
Updated•9 years ago
|
Assignee: nobody → bnicholson
tracking-fennec: ? → +
|
||
Comment 1•9 years ago
|
||
Steph, I think you said you were interested in taking this, so I'm handing it off to you. You'd probably be a better match with all the tabs/UI work you've been doing, but feel free to give it back if you don't want it :)
Assignee: bnicholson → sleroux
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•9 years ago
|
||
Yup sounds good I need to fix the swipe animation anyways because currently it stops rotating after the user stops panning.
|
Reporter | |
Comment 3•9 years ago
|
||
^^ Glad you caught that, was going to file it. Would be cool to continue the same rotation speed etc. throughout the animation
|
|
Assignee | |
Comment 4•9 years ago
|
||
Fixed the animation bug mentioned above and also did some minor refactoring to clean up the animation code.
Attachment #8613058 -
Flags: review?(bnicholson)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8613058 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/525
Looks good, just a couple questions for consideration in the PR.
Attachment #8613058 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Merged
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: noteworthy
You need to log in
before you can comment on or make changes to this bug.
Description
•