1168219 - Make nsIWidget::Configuration::mChild a smart pointer

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try (just linux): https://treeherder.mozilla.org/#/jobs?repo=try&revision=66347be2c6c5
try (everything else): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a19c0b71708e

(I forgot that this patch touched platform specific code when I pushed to try - oops)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make nsIWidget::Configuration::mChild a smart pointer

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21d4e7122064

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21d4e7122064

Comment 4

[Ian Stakenvicius]

Attachment: apply the same fix for widget/qt

The original patch/commit didn't address the same line of code in widget/qt , please consider accepting this patch to allow the caito-qt target to build.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8704314 [details] [diff] [review]
apply the same fix for widget/qt

Doesn't apply cleanly to inbound.

Comment 6

[Ian Stakenvicius]

Attachment: apply the same fix for widget/qt maybecleaner

Re-generated the patch against m-c as of this morning, hopefully this one will apply clean to inbound.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ccd9c22dd04

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ccd9c22dd04