Closed Bug 1168219 Opened 4 years ago Closed 4 years ago

Make nsIWidget::Configuration::mChild a smart pointer

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

try (just linux): https://treeherder.mozilla.org/#/jobs?repo=try&revision=66347be2c6c5
try (everything else): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a19c0b71708e

(I forgot that this patch touched platform specific code when I pushed to try - oops)
Attachment #8610256 - Flags: review?(vladimir)
Blocks: 1114683
Assignee: nobody → michael
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/21d4e7122064
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attached patch apply the same fix for widget/qt (obsolete) — Splinter Review
The original patch/commit didn't address the same line of code in widget/qt , please consider accepting this patch to allow the caito-qt target to build.
Attachment #8704314 - Flags: review?(vladimir)
Attachment #8704314 - Flags: review?(vladimir) → review+
Attachment #8704314 - Flags: checkin?
Comment on attachment 8704314 [details] [diff] [review]
apply the same fix for widget/qt

Doesn't apply cleanly to inbound.
Attachment #8704314 - Flags: checkin?
Re-generated the patch against m-c as of this morning, hopefully this one will apply clean to inbound.
Attachment #8704314 - Attachment is obsolete: true
Attachment #8705216 - Flags: review+
Attachment #8705216 - Flags: checkin?
Attachment #8705216 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.