1168227 - [@ -[NativeMenuItemTarget menuItemHit:] ] crash when trying to update after sleep

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

When I open my MPB after a long duration in sleep while the lid is closed, selecting "Nightly" from the menu will instantly crash nightly. I've ran into this a few times but I don't really have reliable STR.

Crash Report: https://crash-stats.mozilla.com/report/index/431e9f77-d7d2-46a5-ab81-617052150525

STR: (not sure how to reproduce consistently)

- close the MPB lid and let the machine go into sleep mode
- after a while, open the lid and select "Nightly" from menu (it will crash fx instantly)

Now I'm not sure if this is related to there being an update available during the time while the machine was in sleep mode.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Ended up getting a crash while going through basically the same STR from the original comment. Opened the MPB lid and selected "FirefoxDeveloperEdition" so I can select "About Firefox" to update and instantly crashed. However, the crash is a bit different:

https://crash-stats.mozilla.com/report/index/cc366391-1da9-40b6-8011-48aa22150530

Comment 2

[Steven Michaud [:smichaud] (Retired)]

> When I open my MPB after a long duration in sleep while the lid is
> closed, selecting "Nightly" from the menu will instantly crash
> nightly. I've ran into this a few times but I don't really have
> reliable STR.

I just tried this (with today's m-c nightly on OS X 10.10.3) and
didn't see any problems (no crash).

So here are some questions:

1) Is your STR close to 100% effective for you?

2) Do you still see these crashes with today's m-c nightly?

3) Do you see them with a clean profile?

4) What, exactly, do you mean by "selecting "Nightly" from the menu"?

   For example, do you click on Nightly's browser window (to make it
   active), then close your laptop's lid, then choose "Nightly" from
   the (still active) m-c nightly's menu?

   Do you have your machine set to prompt you for a password on waking
   from sleep?  Do you do this before "selecting "Nightly" from the
   menu" and crashing?

Comment 3

[Steven Michaud [:smichaud] (Retired)]

You've got an extension installed that seems to be fairly strongly associated with these crashes:

{2b10c1c8-a11f-4bad-fe9c-1c11e82cac42}

What is it, and does disabling or uninstalling it stop the crashes?

Comment 4

[Steven Michaud [:smichaud] (Retired)]

> {2b10c1c8-a11f-4bad-fe9c-1c11e82cac42}

This is https://addons.mozilla.org/en-US/firefox/addon/ublock/.

Do check if disabling or uninstalling this stops the crashes.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

> 1) Is your STR close to 100% effective for you?

Nope, unfortunately I've tried reproducing it several times (spent about 2 hours trying) and couldn't get it to reproduce. It happens pretty rarely but I've seen it happened at least 5 times in the past month or so.

> 2) Do you still see these crashes with today's m-c nightly?

I'll try with the latest m-c and see if it's still happening but like I mentioned above, it doesn't always happen and it's not easy to reproduce :/ Most of the time the browser updates after opening the lid without any problems.

> 3) Do you see them with a clean profile?

It's always with a profile that's been used for a long time, haven't tried with a completely clean profile but as stated above, it's not really easy to reproduce.

> What, exactly, do you mean by "selecting "Nightly" from the menu"?

So what usually happens is that I have either m-c or m-a running and close the MPB lid while the browser is still opened (usually with a few tabs opened). After a long time (usually after sleeping), I open the the MPB lid and insert my password. While the browser is still opened I click on "Nightly" under the menu so I can check/force an update and as soon as I click on the menu the browser crashes instantly. Sometimes the browser is minimized but the crash always happens once I click on the menu item.

> > {2b10c1c8-a11f-4bad-fe9c-1c11e82cac42}
> 
> This is https://addons.mozilla.org/en-US/firefox/addon/ublock/.
> 
> Do check if disabling or uninstalling this stops the crashes.

Yup, I double checked and that's uBlock 0.9.3.5. I'll uninstall it and see if I can reproduce the crash without the extension. The only downside is that it's really hard to reproduce so that means I won't be able to use the add-on for a least a few weeks/month.

Let me know if there's anything else I can do to get you more information on the crash. Hopefully the above responses are some what helpful :)

Comment 6

[Steven Michaud [:smichaud] (Retired)]

> Let me know if there's anything else I can do to get you more
> information on the crash. Hopefully the above responses are some
> what helpful :)

Thanks for the information!

But if this bug remains so hard to reproduce, I'm not very optimistic
about fixing it.  Even if the association with µBlock pans out, I
don't think these crashes can be µBlock's "fault".

If you discover some other, better way to reproduce this bug, do let
us know -- even if it involves some very complex combination of
extensions and steps.  Pretty much all bugs are fixable once they can
be reproduced.  Very few are fixable without good STR.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #5)
> ...
> Yup, I double checked and that's uBlock 0.9.3.5. I'll uninstall it and see
> if I can reproduce the crash without the extension. The only downside is
> that it's really hard to reproduce so that means I won't be able to use the
> add-on for a least a few weeks/month.

Kamil, did you have good results?

Comment 8

[Kamil Jozwiak [:kjozwiak]]

I've been using uBlock Origin [1] for a few months now and personally haven't ran into any crashes when updating fx after a long period of hibernation. I took a quick look at the [@ -[NativeMenuItemTarget menuItemHit:]] crash and noticed that it's still happening here and there but definitely not at a high rate. Seems like a good portion of the crashes are from Thunderbird as well.

[1] https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #8)
> ... Seems like a good portion of the crashes are from Thunderbird as well.

yes indeed.  Though not bug crash vollume. And stacks vary somewhat. Examples:
bp-0081379b-bb3d-45f1-83a1-54e502160114
bp-bc18a852-d86a-4b7e-8285-810342160114
bp-defb1c80-a85d-435c-bbfc-88ead2160113
bp-08e9e42a-48bf-4ed0-9953-212562160111 (gabriela)

Comment 10

[Josh Aas]

Haven't been able to reproduce and all crash report links are dead now. Closing.