1168274 - Collapse all the resize events before fullscreen to the last one

Status: NEW

(Core :: DOM: Events, enhancement, P5)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently, we dispatch a bunch of resize event before entering fullscreen. We should collapse all of them and only dispatch the last one.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

The resize events are from the change of chrome controls. We probably should prevent those changes to trigger resize event on content.

Comment 2

[Jet Villegas (inactive)]

(In reply to Xidorn Quan [:xidorn] (UTC+12) from comment #1)
> The resize events are from the change of chrome controls. We probably should
> prevent those changes to trigger resize event on content.

That sounds right.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 1 - avoid reflow for hiding window marigns on Windows

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8612584 [details] [diff] [review]
patch 1 - avoid reflow for hiding window marigns on Windows

Review of attachment 8612584 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't see much of a difference visually, seems fine though if it cuts down on event traffic during the transition.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Jim Mathies [:jimm] from comment #4)
> Comment on attachment 8612584 [details] [diff] [review]
> patch 1 - avoid reflow for hiding window marigns on Windows
> 
> Review of attachment 8612584 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I didn't see much of a difference visually, seems fine though if it cuts
> down on event traffic during the transition.

It removes one resize event on Windows according to my test :)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14d7c8dce3e4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/14d7c8dce3e4

Comment 8

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

No.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Looks valid bug to me.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

no

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Comment 18

[Xidorn Quan [:xidorn] UTC+10]

Probably not.

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 20

[Xidorn Quan [:xidorn] UTC+10]

If the leave-open keyword is what you are looking... then let's just remove it :)

Comment 21

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Chatting with :sfarre to follow up the "Points: ?" flag.
The effort to change this behavior may not be large, but it's foreseeable tricky to get it right on various, even edge, test cases. While the change is a valid request/consideration, P5 still sounds the right priority.