Collapse all the resize events before fullscreen to the last one

NEW
Unassigned

Status

()

P5
normal
4 years ago
5 months ago

People

(Reporter: xidorn, Unassigned)

Tracking

(Blocks: 1 bug, {leave-open, parity-chrome})

Trunk
leave-open, parity-chrome
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Currently, we dispatch a bunch of resize event before entering fullscreen. We should collapse all of them and only dispatch the last one.
(Reporter)

Updated

4 years ago
Summary: Reduce the resize event before fullscreen to one the last one → Collapse all the resize events before fullscreen to the last one
(Reporter)

Comment 1

4 years ago
The resize events are from the change of chrome controls. We probably should prevent those changes to trigger resize event on content.
(In reply to Xidorn Quan [:xidorn] (UTC+12) from comment #1)
> The resize events are from the change of chrome controls. We probably should
> prevent those changes to trigger resize event on content.

That sounds right.
(Reporter)

Updated

4 years ago
Depends on: 1168705
(Reporter)

Updated

4 years ago
Keywords: leave-open
(Reporter)

Comment 3

4 years ago
Created attachment 8612584 [details] [diff] [review]
patch 1 - avoid reflow for hiding window marigns on Windows
Attachment #8612584 - Flags: review?(jmathies)

Comment 4

4 years ago
Comment on attachment 8612584 [details] [diff] [review]
patch 1 - avoid reflow for hiding window marigns on Windows

Review of attachment 8612584 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't see much of a difference visually, seems fine though if it cuts down on event traffic during the transition.
Attachment #8612584 - Flags: review?(jmathies) → review+
(Reporter)

Comment 5

4 years ago
(In reply to Jim Mathies [:jimm] from comment #4)
> Comment on attachment 8612584 [details] [diff] [review]
> patch 1 - avoid reflow for hiding window marigns on Windows
> 
> Review of attachment 8612584 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I didn't see much of a difference visually, seems fine though if it cuts
> down on event traffic during the transition.

It removes one resize event on Windows according to my test :)
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome
Whiteboard: [parity-blink]

Updated

5 months ago
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.