1168326 - Replace SpecialPowers in selection_helper.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

SpecialPowers has been removed from marionette (might related to bug 1149618).
We need a new way to get intput/textarea 's selection and enable disabled marionette test cases.

Comment 1

[Jeremy Chen ([e-mail])]

(In reply to George Duan [:gduan] [:喬智] from comment #0)
> SpecialPowers has been removed from marionette (might related to bug
> 1149618).
> We need a new way to get intput/textarea 's selection and enable disabled
> marionette test cases.

I tried the new way, which uses client.scope({ context: 'chrome' }).executeScript(script, [args]), but failed to pass element into script. I can pass string, int, even element's attribute, just can't pass element itself. Still figuring it out.

Comment 2

[Jeremy Chen ([e-mail])]

SpecialPowers has been removed from marionette in bug 1149618, but somehow SpecialPowers was not removed in selection_helper.js yet. To remove that, we could enable parameter "sandbox" for executeScript(), which is already enabled in Marionette Python Client. In my first commit, I enable parameter "sandbox" for executeScript() and fix the unit-test. In my second commit, I use the newly supported executeScript() to remove the use of SpecialPowers.

Comment 3

[Jeremy Chen ([e-mail])]

Attachment: PR

Comment 4

[Jeremy Chen ([e-mail])]

Comment on attachment 8615175 [details] [review]
PR

Hi Gareth, could you check this patch? Thanks.

Comment 5

[Jeremy Chen ([e-mail])]

Comment on attachment 8615175 [details] [review]
PR

Remove review request first. I'll split the PR into two separate parts: one for test file and one for marionette-client library. Then, I'll send review requests.

Comment 6

[Jeremy Chen ([e-mail])]

Attachment: [gaia] PR to Gij test file

SpecialPowers has been removed from marionette in bug 1149618, but somehow SpecialPowers was not removed in selection_helper.js yet. To remove that, we could use parameter "sandbox" for executeScript(), which is already enabled in Marionette Python Client.

This patch could be check-in once the patch for JSmarionette (gaia/marionette-js-client and node_modules) is r+ and landed.

Comment 7

[Jeremy Chen ([e-mail])]

Attachment: [gaia] PR to jsmarionette/client/marionette-client

Enable parameter "sandbox" for executeScript(), which is already enabled in Marionette Python Client. The unit-test is also patched. With this patch, we can execute script with system privilege in marionette-js-client.

Comment 8

[Jeremy Chen ([e-mail])]

Attachment: Bug1168326_node_modules.patch

This patch is for gaia node_modules so we can test Gij manually.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8615847 [details] [review]
[gaia] PR to Gij test file

Thank you for fixing it. I have no concern for gaia part if the tests pass. Please make sure your patch to marionette-client is landed first.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8615849 [details] [review]
[gaia] PR to jsmarionette/client/marionette-client

LGTM!

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/37868e7816290f1c92e180fda4dad6f5c0cee855

Comment 12

[Jeremy Chen ([e-mail])]

Patch to marionette-client has been landed a while. Since test result for Gaia test file looks positive, please land the "[gaia] PR to Gij test file". Thanks. :)

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

tests are green,
master: https://github.com/mozilla-b2g/gaia/commit/5643e3d85c41544eae79279f5f75dad0af512cce