11684 - [infinite loop] bugs - nsTextEditor.cpp

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Jay Patel [:jay]]

Analysis of the code has determined possible infinite loop
or problem in the code below.  See bug
http://bugzilla.mozilla.org/show_bug.cgi?id=11588
for more information

nsTextEditor.cpp:1570: warning: unsigned value < 0 is always 0
nsTextEditor.cpp:1648: warning: unsigned value < 0 is always 0

Comment 1

[Akkana Peck]

nsTextEditor.cpp is no longer in the build, but nsHTMLEditor.cpp, where
mWrapColumn moved, still has the problem that mWrapColumn is declared as
unsigned but sometimes used as signed.  I don't see the infinite loop (I'll look
more closely later to make sure there isn't one) but there are definitely issues
here to be addressed (and I'm surprised it didn't show up as a warning).

Good catch, thanks for the report!

Comment 2

[Akkana Peck]

Fix (making mWrapColumn a signed int) will go in when the tree opens for M10.

Comment 3

[Akkana Peck]

A fix has been checked in; we no longer keep mWrapColumn at all, but instead get
it from the current style, so we know we won't get out of sync.

Code level fix, QA should just go ahead and mark verified unless the submitter
wants to verify it.

Comment 4

[leger]

Marking Verified per last comments