Closed
Bug 1168501
Opened 9 years ago
Closed 9 years ago
Timed syncs for history
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Whiteboard: noteworthy)
Attachments
(1 file)
This is very under-specified right now.
|
Assignee | |
Comment 1•9 years ago
|
||
We want this for history sync. Necessary: backoff!
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
This is on top of basic backoff handling, earlier in the PR. We kick off a 15-minute timer when the app is foregrounded, and stop it when we go bye-bye. Backoff handling -- or no account, or any other NotStarted cause -- will cause the sync to short-circuit fail with no work being done, so this timer is very cheap; this is a little simpler than twisting together both the app lifecycle and account state.
Attachment #8613848 -
Flags: review?(sarentz)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8613848 [details] [review] Pull req. LGTM. Just added a comment about the weak AppDelegate.profile, which I think may not be correct or at least not do what you would expect.
Attachment #8613848 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/1e49f204790b9d83e6129e4436617f5c815166b2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Summary: Timed syncs → Timed syncs for history
Whiteboard: noteworthy
You need to log in
before you can comment on or make changes to this bug.
Description
•