1168516 - Enable developer menu by default in Spark customization

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

See bug 1163889 comment 7.

The developer menu might be enabled by default if we ship with userdebug, but we can just enable within the Spark customization to be safe. We don't yet know what build we're going to be shipping with specifically, so we could also wait until we know and RESOLVE INVALID this if necessary.

Comment 1

[Doug Sherk (:drs) (inactive)]

Dale, what do you think? I'm leaning towards just setting this anyways and backing it out later if we don't need it. If you want to go ahead with this, could you take it?

Comment 2

[Dale Harvey (:daleharvey)]

Will do

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1168516 > mozilla-b2g:master

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8611284 [details] [review]
[gaia] daleharvey:1168516 > mozilla-b2g:master

So I actually dont think we should depend on user vs userdebug vs eng build for these type of settings. We have done in the past and its always fustrating to be asking 'are you using an engineering build etc'

I think they should be explicitly enabled, hence the developer menu enabled by default too (its also usually disabled by default)

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8611284 [details] [review]
[gaia] daleharvey:1168516 > mozilla-b2g:master

(In reply to Dale Harvey (:daleharvey) from comment #4)
> Comment on attachment 8611284 [details] [review]
> [gaia] daleharvey:1168516 > mozilla-b2g:master
> 
> So I actually dont think we should depend on user vs userdebug vs eng build
> for these type of settings. We have done in the past and its always
> fustrating to be asking 'are you using an engineering build etc'
> 
> I think they should be explicitly enabled, hence the developer menu enabled
> by default too (its also usually disabled by default)

Yeah, I agree, and that makes sense.

I'm r-'ing only because we can't enable developer mode by default due to security concerns. Please remove that line and enable only the "developer.menu.enabled" setting. If you'd like more background info, see bug 1160235 comment 8.

Comment 6

[Dale Harvey (:daleharvey)]

Merged in https://github.com/mozilla-b2g/gaia/commit/5f4840b5bb08803fc6df294bcbd4ea2ef2228b41