Add context menu option for "Show password"

RESOLVED FIXED in Firefox 41

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: liuche, Assigned: liuche)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 41
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
The original plan was to have this as part of "Edit login" > "Show password" but we should surface this earlier and make it easier, because this is probably what people do *most* of the time.

This bug is to add "Show password" to the context menu, and when tapping on that, close the first context menu and then open a new dialog that is just the text of the password.
(Assignee)

Updated

2 years ago
Assignee: nobody → liuche
(Assignee)

Comment 1

2 years ago
Created attachment 8614424 [details]
Screenshot: Show password dialog

Hm, I'm not sure how I feel about this. I'd prefer just the single line dialog, but it's not long-pressable without a bit of hacking.
(Assignee)

Comment 2

2 years ago
Created attachment 8614442 [details]
Screenshot: Show password dialog v2
(Assignee)

Comment 3

2 years ago
Created attachment 8614455 [details]
MozReview Request: Bug 1168530 - Add context menu option for "Show password". r=ally

Bug 1168530 - Add context menu option for "Show password". r=ally
Attachment #8614455 - Flags: review?(ally)
(Assignee)

Comment 4

2 years ago
Friendly review ping - this should be really quick.
Flags: needinfo?(ally)
Attachment #8614455 - Flags: review?(ally) → review+
Comment on attachment 8614455 [details]
MozReview Request: Bug 1168530 - Add context menu option for "Show password". r=ally

https://reviewboard.mozilla.org/r/9961/#review9145

Ship It!

::: mobile/android/chrome/content/aboutPasswords.js:181
(Diff revision 1)
> +                // Corresponds to "Copy password" button.

I still really dislike the hardcoded button order. Thank you for the comment

::: mobile/android/locales/en-US/chrome/aboutPasswords.properties:5
(Diff revision 1)
> +passwordsMenu.showPassword=Show password

Doesn't look like anything here would be incorrect after the rename from about:passwords to about:logins .
Flags: needinfo?(ally)
(Assignee)

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/01a6f68c4e53
(Assignee)

Updated

2 years ago
Attachment #8614424 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/01a6f68c4e53
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.