Closed Bug 1168530 Opened 5 years ago Closed 5 years ago
Add context menu option for "Show password"
The original plan was to have this as part of "Edit login" > "Show password" but we should surface this earlier and make it easier, because this is probably what people do *most* of the time. This bug is to add "Show password" to the context menu, and when tapping on that, close the first context menu and then open a new dialog that is just the text of the password.
Hm, I'm not sure how I feel about this. I'd prefer just the single line dialog, but it's not long-pressable without a bit of hacking.
Bug 1168530 - Add context menu option for "Show password". r=ally
Attachment #8614455 - Flags: review?(ally)
Friendly review ping - this should be really quick.
Attachment #8614455 - Flags: review?(ally) → review+
Comment on attachment 8614455 [details] MozReview Request: Bug 1168530 - Add context menu option for "Show password". r=ally https://reviewboard.mozilla.org/r/9961/#review9145 Ship It! ::: mobile/android/chrome/content/aboutPasswords.js:181 (Diff revision 1) > + // Corresponds to "Copy password" button. I still really dislike the hardcoded button order. Thank you for the comment ::: mobile/android/locales/en-US/chrome/aboutPasswords.properties:5 (Diff revision 1) > +passwordsMenu.showPassword=Show password Doesn't look like anything here would be incorrect after the rename from about:passwords to about:logins .
Attachment #8614424 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.