1168533 - Add @skip_under_xvfb to test (not to class)

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Barbara Miller (:galgeek)]

The tests in functional/locationbar currently use the decorator @skip_under_xvfb applied to the class, not the test, and have been silently failing to run.

It would be good to check other tests for similar silent failures to run.

Comment 1

[Barbara Miller (:galgeek)]

Attachment: github pull request

This patch fixes up the functional/locationbar tests.

Maybe there are others?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8610756 [details] [review]
github pull request

See my comment on thE PR.

Comment 3

[Barbara Miller (:galgeek)]

Comment on attachment 8610756 [details] [review]
github pull request

Thanks for your feedback, Henrik!

I’ve sorted the locationbar manifest and commented out test_access_location_bar there for now. This patch passes travis.

I also did a quick grep for other tests using skips, and it looks like all others are already applied to the test, not the class.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8610756 [details] [review]
github pull request

That one we can definitely land! Thanks Barbara. I will make a short edit of the manifest so we skip it correctly. Using comments is not the right way.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/39942fb1c5bd5fd55e98f07939e733753e463624 (master)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/1d506585c1fd8ce9167c16b5473e1c1390aa44d3 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/42295df0bd634178e623b9f14e6a391259a1ac7e (beta)

mozilla-release and mozilla-esr38 branches got rebased against beta, so they have the same changeset.