Closed Bug 1168538 Opened 5 years ago Closed 5 years ago

CSP: Add compiled code test for referrer directive to TestCSPParser

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ckerschb, Assigned: franziskus)

References

Details

Attachments

(1 file, 1 obsolete file)

We should extend CSP parser tests to also include the referrer directive [1], potentially also upper and lower case tests, etc.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/base/test/TestCSPParser.cpp#187
Assignee: nobody → franziskuskiefer
Blocks: 704320
Comment on attachment 8612534 [details] [diff] [review]
adding compiled code test for referrer directive to TestCSPParser (r=ckerschb)

Review of attachment 8612534 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks!

::: dom/base/test/TestCSPParser.cpp
@@ +278,5 @@
> +      "script-src 'sha256-siVR8vAcqP06h2ppeNwqgjr0yZ6yned4X2VF84j4GmI='" },
> +    { "reFerREr nO-refERrer",
> +      "referrer nO-refERrer" },
> +    { "refERRer No-refeRRer",
> +      "referrer No-refeRRer" },

only keep that one in the middle and delete the other two please.
Attachment #8612534 - Flags: review?(mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75f254f7c7f8
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.