Closed Bug 1168586 Opened 5 years ago Closed 5 years ago

Coverity complains about AutoEnterOOMUnsafeRegion::oomAfter_ not being initialized

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: mccr8, Assigned: jonco)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [cid 1299630])

Attachments

(1 file)

It complains about this, despite the fact that it is only accessed when oomEnabled_ is true. Maybe oomEnabled_ can be made const and then Coverity could figure out that it is only used when initialized?
Considering this is debug only code, can we just initialize it?
I get this as a warning from gcc too:

js/src/jsgc.h:1422:57: warning: ‘oomUnsafeRegion.js::gc::AutoEnterOOMUnsafeRegion::oomAfter_’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Assignee: nobody → jcoppeard
Let's just initialize it.
Attachment #8612175 - Flags: review?(terrence)
Attachment #8612175 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/c1771a883c1e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.