1168586 - Coverity complains about AutoEnterOOMUnsafeRegion::oomAfter_ not being initialized

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Andrew McCreight [:mccr8]]

It complains about this, despite the fact that it is only accessed when oomEnabled_ is true. Maybe oomEnabled_ can be made const and then Coverity could figure out that it is only used when initialized?

Comment 1

[Eric Rahm [:erahm]]

Considering this is debug only code, can we just initialize it?

Comment 2

[Jon Coppeard (:jonco)]

I get this as a warning from gcc too:

js/src/jsgc.h:1422:57: warning: ‘oomUnsafeRegion.js::gc::AutoEnterOOMUnsafeRegion::oomAfter_’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1168586-oomAfter-init

Let's just initialize it.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1771a883c1e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1771a883c1e