1168720 - Remove use of test env var MOZ_NO_REPLACE_FALLBACK and associated tests that are covered by other tests

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

I've been planning on removing as much test specific code from the client binaries which is much simpler now that there is a test updater and tests that are already covered by other tests. The MOZ_NO_REPLACE_FALLBACK env var isn't needed and the tests that use this env var are for the most part already covered by other tests and with a few changes these tests can completely cover those tests.

Patch coming up soon.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecd281495ea3

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8611071 [details] [diff] [review]
patch rev1

Removes 14 Windows only tests! :)

Comment 3

[Robert Strong (they/them - no direct email)]

Note regarding the try run. I used --tag appupdate which causes the mochitest-other tests to report failure on treeherder due to there being multiple test suites and treeherder reporting failures if any of the test suites don't run any tests (see bug 1162355). I've looked at the logs and verified that all of the mochitest-other tests passed.

Comment 4

[Robert Strong (they/them - no direct email)]

The Windows builds systems suffered an automation error so here is a Windows only try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca2e72b8cc66

Comment 5

[Robert Strong (they/them - no direct email)]

Yay again... this removes two tests that have been intermittent! Bug 1112284 and bug 1166989

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8611071 [details] [diff] [review]
patch rev1

Try runs look great!

Comment 7

[Stephen A Pohl [:spohl]]

Comment on attachment 8611071 [details] [diff] [review]
patch rev1

Review of attachment 8611071 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js
@@ +3374,5 @@
>   *
>   * Command line arguments used when launching the application:
>   * -no-remote prevents shell integration from being affected by an existing
>   * application process.
> + * -test-process-updates makes the application exits after being relaunched by

nit: s/exits/exit/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e2c4ccb516bd

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2c4ccb516bd