1168763 - [Settings - Internet sharing] Hotspot settings is not accessible when hotspot is turned on

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jenny Lee]

[1.Description]:
Hotspot settings is not accessible when hotspot is turned on.

[2.Testing Steps]: 
1. Go to Settings > Internet sharing
2. Turn on Wi-Hi hotspot
3. Try to access hotspot settings

[3.Expected Result]: 
User can still access hotspot settings (make change, see password etc). 

[4.Actual Result]:
Hotspot settings is disabled.

Comment 1

[Jenny Lee]

Attachment: [Settings] Internet Sharing v1.2.pdf

Hi Arthur,

Per discussion, under certain circumstances, user may still need to access hotspot settings when Wi-Fi is turned on (for example, see password). Can we make the change as specified in spec p.5 screen 2? Thanks!

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/30404

EJ, could you help review this patch? Thanks!

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8615238 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30404

Thanks Arthur, this patch looks great, r+!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/e3d0d06f5aa2f4bdce671a04565d47748c088db0

Comment 6

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: After turning on the Wi-Fi Hotspot, user still can access hotspot settings to change the Password/SSID Network Name/Security (or check/uncheck "Show password").

See attachment: verified_v3.0.mp4
Reproduce rate: 0/6

Device: Flame v3.0 build(Pass)
Build ID               20150608010204
Gaia Revision          1d62b32408567f9f7cf1c71c1e5a0c6593be757b
Gaia Date              2015-06-05 17:55:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7d4ab4a9febd
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150608.043454
Firmware Date          Mon Jun  8 04:35:05 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Pass)
Build ID               20150608010204
Gaia Revision          1d62b32408567f9f7cf1c71c1e5a0c6593be757b
Gaia Date              2015-06-05 17:55:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7d4ab4a9febd
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150608.043126
Firmware Date          Mon Jun  8 04:31:41 EDT 2015
Bootloader             HHZ11k

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4