1168783 - expose principal in mozIApplication

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1168300#c4
"it would be better for mozIApplication to expose a principal."

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8614692 [details] [diff] [review]
v1

Review of attachment 8614692 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I don't think  this is the right approach. I'd rather add a principal getter on mozIApplication.prototype because cloneAppObject() uses _setAppProperties but we don't want the principal on cloned objects (we expect them to be stringifyable).

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v2

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8615952 [details] [diff] [review]
v2

Review of attachment 8615952 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/AppsUtils.jsm
@@ +84,5 @@
> +        this.localId,
> +        this.installerIsBrowser
> +      );
> +    } catch(e) {
> +      dump("Could not create app principal " + e + "\n");

that means we will return undefined if we end up there. Can we either force to return null here or initialize _principal to null in the constructor?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/909aa8a5fd1c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/909aa8a5fd1c