1168823 - XML view no longer has colour styles

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[:Gijs (he/him)]

Noticed this while trying to work on some XBL.

Comment 1

[:Gijs (he/him)]

view-source-in-a-tab seems to have regressed XML display. mozregression found the following range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=afb28a3157b3&tochange=5f7e75cf1891

Ryan, do you know what's up here?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, I see the issue.  XML view is missing the new highlight class.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6452fbb49041

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1168823-Repair-XML-syntax-highlighting.-r-jst.patch

:jst, in bug 1067325, I changed the syntax highlighting in "viewsource.css" to be controlled by a CSS class "highlight".  However, I missed that this is also used in the XML view.

This change adds the missing class.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Fixed broken mochitest:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbad53067031

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2aae3415da8b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2aae3415da8b