Closed Bug 1168868 Opened 8 years ago Closed 8 years ago

Settings UI should better match the rest of the app

Categories

(Firefox for iOS :: Theme & Visual Design, defect)

Product:
Firefox for iOS
Component:
Theme & Visual Design
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fennec + ---
fxios + ---

People

(Reporter: dhenein, Assigned: fluffyemily)

Details

Attachments

(2 files)

Settings - Signed In v1.png
116.05 KB, image/png
Details
Pull request
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review 
We have a mockup for the settings UI which should be followed. This is not about the exact settings/labels that appear in the mockup, but rather the spacing/typography/color.

Ping darrin or tecgirl for clarification if needed.
Emily, you interested in this?
Assignee: nobody → etoop
Yeah, I can take this one
There's a suggestion in vague bug 1169143 for changing the UISwitch tint colour for search settings. Not a whole lot of information but maybe this makes sense as a tweak to be included here.
Attached file Pull request — 

        Attachment #8614661 -
        Flags: review?(bnicholson)
tracking-fennec: ? → +

          tracking-fxios:
          --- → +

    
    

    
  
Comment on attachment 8614661 [details] [review]
Pull request

Looks good with mostly minor nits, but I'd like to understand what's going on in layoutSubviews before setting r+.

        Attachment #8614661 -
        Flags: review?(bnicholson) → feedback+

    
    

    
  
Comment on attachment 8614661 [details] [review]
Pull request

https://github.com/mozilla/firefox-ios/pull/549# for feedback

        Attachment #8614661 -
        Flags: feedback+ → review?(bnicholson)

    
    

    
  
Comment on attachment 8614661 [details] [review]
Pull request

Nice, looks good!

        Attachment #8614661 -
        Flags: review?(bnicholson) → review+

    
  
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.