1168868 - Settings UI should better match the rest of the app

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Darrin Henein [:darrin]]

Attachment: Settings - Signed In v1.png

We have a mockup for the settings UI which should be followed. This is not about the exact settings/labels that appear in the mockup, but rather the spacing/typography/color.

Ping darrin or tecgirl for clarification if needed.

Comment 1

[Wesley Johnston (:wesj)]

Emily, you interested in this?

Comment 2

[Emily Toop (:fluffyemily)]

Yeah, I can take this one

Comment 4

[Aaron Train [:aaronmt]]

There's a suggestion in vague bug 1169143 for changing the UISwitch tint colour for search settings. Not a whole lot of information but maybe this makes sense as a tweak to be included here.

Comment 5

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8614661 [details] [review]
Pull request

Looks good with mostly minor nits, but I'd like to understand what's going on in layoutSubviews before setting r+.

Comment 7

[Emily Toop (:fluffyemily)]

Comment on attachment 8614661 [details] [review]
Pull request

https://github.com/mozilla/firefox-ios/pull/549# for feedback

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8614661 [details] [review]
Pull request

Nice, looks good!