1168889 - B2G Desktop animations flicker a lot since bug 1152461

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Paul Rouget [:paul]]

- B2G Desktop
- OSX
- hw-vsync
- apzc

Animations (opacity & 2d transforms) flicker a lot on Desktop since bug 1152461.

Reverting the patch, animations are smooth again, but I get this warning:

[Parent 25537] WARNING: Tiled PaintedLayer with no scrollable container ancestor: file /Users/paul/mozilla/src/gfx/layers/client/ClientTiledPaintedLayer.cpp, line 150

Comment 1

[Paul Rouget [:paul]]

Clarification: the warning only appears if apzc is turned off. Whether apzc is on or off, animations still flicker.

Comment 2

[Markus Stange [:mstange]]

Please tell me how to run B2G Desktop. I cloned the gaia repository, executed make, and tried to run the profile with B2G desktop downloaded from https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/b2g-41.0a1.en-US.mac64.dmg , and all I got was a small black window with a home button and a back button and the output:
JavaScript error: chrome://b2g/content/shell.js, line 14: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]

Comment 3

[Paul Rouget [:paul]]

Attachment: test case

STR:
- run B2G with Gaia
- open attached test case as a web page
- important: make the B2G window larger
- move mouse over the page
- see flickering

Comment 4

[Paul Rouget [:paul]]

Attachment: screencast

Comment 5

[Paul Rouget [:paul]]

(In reply to Markus Stange [:mstange] from comment #2)
> Please tell me how to run B2G Desktop. I cloned the gaia repository,
> executed make, and tried to run the profile with B2G desktop downloaded from
> https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/
> b2g-41.0a1.en-US.mac64.dmg , and all I got was a small black window with a
> home button and a back button and the output:
> JavaScript error: chrome://b2g/content/shell.js, line 14:
> NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff
> (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]

I have the same issue… I don't know how nightlies work.
I usually just build B2G (with --enable-application=b2g in mozconfig) and then run with `./mach run --profile gaia/profile`.

Also, see screencast and test case attached.

I think the bug is more visible with hardware vsync.

Comment 6

[Markus Stange [:mstange]]

It looks like B2G Desktop OS X is now using ContentClientSingleBuffered for non-scrollable PaintedLayers. Is that bad? Are there known bugs in ContentClientSingleBuffered? The flickering / tearing looks like what you'd get if we were uploading to the texture at the same time that the main thread is painting into the buffer.

Comment 7

[Markus Stange [:mstange]]

By the way, thanks for the tip with the local build, Paul, it's working for me now. (Though I had to edit the prefs in the profile's user.js file; the preferences app wouldn't actually let me access any pref panes.)

Comment 8

[Markus Stange [:mstange]]

Attachment: patch

Comment 9

[Markus Stange [:mstange]]

The upload was happening outside the transaction, while the main thread was already painting the next frame into the shared buffer.

Comment 10

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f35f52f7274

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2f35f52f7274