Closed
Bug 116892
Opened 23 years ago
Closed 22 years ago
alladyn.art.pl - problems with layout and/or styles on this page
Categories
(Tech Evangelism Graveyard :: Polish, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: zbraniecki, Assigned: nikolai)
References
()
Details
(Whiteboard: bad JS?)
Starting from Mozilla 0.9.7 on our project page external CSS seems to be not
loaded.
I dont know how on other platforms, i'm talking only about PC.
I'm afraid about styles added to layers whitch are created dynamicly...
Greets
Zbigniew Braniecki
Comment 1•23 years ago
|
||
Please make sure the stylesheet is served as text/css. From 0.9.7 on, only
stylesheets served as text/css will be used as css file.
Reporter | ||
Comment 2•23 years ago
|
||
I'm shure it's saved as a text/css and it's declarated as it.
Still think it's bug.
Greets
Zbigniew Braniecki
Comment 3•23 years ago
|
||
the file http://alladyn.art.pl/al.css is not valid, it doesn't have to include the
<style type="text/css"> tag, and the comment. <!-- -->
You can validate the page with the following web:
http://jigsaw.w3.org/css-validator/validator-uri.html
Comment 4•23 years ago
|
||
Reporter, does the page work if you fix the broken css files? The invalid
<style> and <!-- comment causes at least the first style declaraction in the css
files to be ignored, but this is *not* a bug in mozilla, mozilla is supposed to
do that, just as stated in the W3C CSS spec.
Comment 5•23 years ago
|
||
Regardless of whether fixing the broken CSS fixes this problem or not, it
doesn't look like a DOM Style bug. Over to Style System.
Assignee: jst → dbaron
Component: DOM Style → Style System
Reporter | ||
Comment 6•23 years ago
|
||
Hummm... removed comments and <style> tag, but still doesnt appear in a right
way...
Strange, cause in ns4,ns6,Mozilla 0.9.6,Ie it works...
So... can i say it's a bug?
Comment 7•23 years ago
|
||
Certainly sounds like this is not one of the known problems... there
are no odd characters in the file (though someone with a debug build
should see whether the decoding error assertion is triggered). The
mime type is correct.
Zbigniew, could you please try the following:
1) Change "./al.css" to "al.css" in the <link> element?
2) Change "LINK" to "link"?
3) Open up DOM inspector and see what it thinks the loaded sheets are for the
document and where they are loaded from?
Reporter | ||
Comment 8•23 years ago
|
||
Ready... no change...
But! Found new errors.
First of all redeclaration of const whotch about i told in #117011 .
Second thing is that DOM Inspector says it's all ok... found file, recognized
styles... but did not add them to layers.
Greets
Gandalf
Comment 9•23 years ago
|
||
Two other thoughts...
1) does adding |type="text/css"| to the <link> element help?
2) does removing the <!DOCTYPE> line (putting the page in quirks mode) help?
Reporter | ||
Comment 10•23 years ago
|
||
1) no
2) yes. Helped. I got bad Doctype? Or it's Mozilla error?
Thanks for help anyway, and hope it'll help You :)
Comment 11•23 years ago
|
||
OK. I finally took the plunge and read the incredibly obfuscated javascript.
The problem seems to be with things like:
"top:80,left:230"
which get passed to the function "vkf". In standards mode units are required on
those lengths. Try changing those to "top:80px,left:230px" and see whether that
helps.
Comment 12•23 years ago
|
||
Zbigniew Braniecki:
Can you post a copy of the page HTML as it was when you filed this bug (or in a
recent state after some changes mentioned by people in this bug that don't
work)? It seems as there is an issue that needs resolving and I understand if
you want to include this workaround on your homepage, but to diagnose it fully,
a copy would be needed.
If the page used to have an XHTML doctype, the <link/> element is not properly
closed with a trailing slash which might cause this.
Reporter | ||
Comment 13•23 years ago
|
||
Christopher:
You can still check buggy version under
http://alladyn.art.pl/eng/index.html or links on the page.
I removed doctype only from fisrt page.
I checked with <link/> but it's not this.
Boris. Thanks I'll check it, but i dont think it's a solution.
vkf() is a part of Alladyn library used for animation on this page, but not for
positioning all layers. And when I'm checking on test pages positioning
without "px" it works quite good.
Comment 14•23 years ago
|
||
Positioning without units works only on pages that are being rendered in
"quirks" mode. The page in question is in "standards" mode due to the XHTML
doctype and in this mode positioning without units should not work. Hence my
suggestion.
Reporter | ||
Comment 15•23 years ago
|
||
Boris... but..,. in *.css file there is px...
I added some px in http://alladyn.art.pl/eng/docs.html to test Your suggestion..
No change.
Comment 16•23 years ago
|
||
Zbigniew, you said you were seeing problems with the _dynamic_ "layers". So I
was looking at the script part, especially since you said that DOM inspector
showed the CSS as being loaded correctly.
Could you please clearly explain exactly which styles are not applied that you'd
expect to be applied and to which elements you expect them to be applied?
Comment 17•23 years ago
|
||
Also, note that I suggested adding units in the js, not in the HTML...
Reporter | ||
Comment 18•23 years ago
|
||
Ok, Ok.
First of all, I'm talking about css style positioning of layers.
Nothing about JavaScript.
Please, follow the example: http://alladyn.art.pl/eng/docs.html and tell me,
why those layers aren't positioned? Test it on Mozilla 0.9.6 or IE4,5,6 or NS4
and You'll see how it should look like.
After Christopher's help, i removed DOCTYPE from
http://alladyn.art.pl/index.html and it works.
Sorry, could You explain "adding units" ?
Comment 19•23 years ago
|
||
I am having this problem as well. My page validates as both valid CSS and valid
XHTML using W3C's validation pages, yet the CSS is not loaded.
Comment 20•23 years ago
|
||
It is clear to me that the CSS file *is* loading. The background image and
a:hover rules are set properly.
Zbigniew, by units Boris meant 'px' (pixels). I think that Boris is correct
when he said that you need your JS to specify the units. In standards mode, you
must have them as the specification says, even if it is CSS being set via
JavaScript, it still applies. 5 is just a number. 5 what? inches?
centimeters? pixels? percent? If you apply px to what Boris said, I am
confident your problem will be fixed.
Carey Tilden: your issue is separate and probably should be filed as a separate
bug, but make sure your webserver is sending the CSS as text/css and not
anything else before filing.
Reporter | ||
Comment 21•23 years ago
|
||
How do You imagin this error?
In fact, most of layers aren't even touch by JS... the only thing positioning
most of layers are CSS declarations... and those declarations have "px"...
I event made tests with deleting any JS files and functions but still layers
weren't posintioned propertly...
And I cant imagin situation, that bad value writed to property (i.e.
style.left) of one layer makes bad posiion of another...
Comment 22•23 years ago
|
||
Reporter, if you have a simplified testcase showing the "layer" positioning
problems w/o any JS, please attach the testcase.
Comment 23•23 years ago
|
||
I have the same problem with external style sheets starting with Mozilla 0.9.7
under Linux. Removing the DOCTYPE solves the problem, but is not an option as it
makes the page invalid XHTML. It also removes entities such as umlauts.
I prepared some testcases at
http://www-users.cs.umn.edu/~stoeter/bugzilla/116892/ in which text containing
an umlaut should be displayed with a green background color and red text color.
It does not work for the external CSS case.It works for the no preamble case,
but the page is no longer XHTML compatible.Note that the umlaut is rendered
correctly, but the w3 validator complains about it.
Comment 24•23 years ago
|
||
Re-summarizing this as the CSS files clearly get loaded.
Sascha, see http://www.mozilla.org/releases/mozilla0.9.7/#devel (2nd graf) to
fix your issue.
Summary: external css file doesn't load → alladyn.art.pl - problems with layout and/or styles on this page
Whiteboard: bad JS?
Comment 25•23 years ago
|
||
OK. This is _so_ an evangelism issue. See
http://www.zbarsky.org:8000/~bzbarsky/alla.html -- this is a copy of the site in
which I have added "px" all over to lengths in the CSS and js. The copy has a
4.01 Strict doctype and works almost correctly (the console does not disappear,
but that's about it). You can look at the changed scripts
(http://www.zbarsky.org:8000/~bzbarsky/one.js and
http://www.zbarsky.org:8000/~bzbarsky/two.js to see what I changed).
So this is just a bug in Alladyn library, which only works on pages that are in
quirks mode. Over to evangelism.
Assignee: dbaron → prokosch
Status: UNCONFIRMED → NEW
Component: Style System → Europe: East
Ever confirmed: true
Product: Browser → Tech Evangelism
QA Contact: ian → momoi
Version: other → unspecified
Reporter | ||
Comment 26•23 years ago
|
||
Ya. Right.
Sorry for all mess. We'll add 'px' :)
And little question. 'px' has to be added only once, yes?
Comment 27•23 years ago
|
||
The final value you assign into the style.top has to be "2px" or something like
that. See the fixed version of your site that I posted...
Reporter | ||
Comment 28•22 years ago
|
||
Ok. My problem was fixed long ago. I belive i wont break any rule if i'd close
it by myself?
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•