Closed Bug 1168933 Opened 6 years ago Closed 6 years ago

No worker referrer

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: franziskus, Assigned: nsm)

References

Details

Attachments

(1 file, 1 obsolete file)

When querying a worker [1] firefox never sends a referrer, i.e. referrer policies have no effect.

[1] https://html.spec.whatwg.org/multipage/workers.html
Assignee: nobody → amarchesini
Attached patch referrer.patch (obsolete) — Splinter Review
I used the same code of XHR: in case we have a parentDoc I use the documentURI of that document, otherwise the parent principal.
Attachment #8612918 - Flags: review?(bugs)
Comment on attachment 8612918 [details] [diff] [review]
referrer.patch

copy-pasting this much code feels wrong, and I think bug 1169044 is adding some helper.
Attachment #8612918 - Flags: review?(bugs) → review-
Depends on: 1169044
Comment on attachment 8612918 [details] [diff] [review]
referrer.patch

Andrea, I've just updated the patch to use the function. Thanks for the test.
Attachment #8612918 - Attachment is obsolete: true
Comment on attachment 8615694 [details]
MozReview Request: Bug 1168933 - Send referrer when downloading worker script. r?smaug

Perhaps kyle could review this too.
Attachment #8615694 - Flags: review?(bugs) → review?(khuey)
Comment on attachment 8615694 [details]
MozReview Request: Bug 1168933 - Send referrer when downloading worker script. r?smaug

Bug 1168933 - Send referrer when downloading worker script. r?smaug
Attachment #8615694 - Flags: review?(khuey) → review?(bugs)
Attachment #8615694 - Flags: review?(bugs) → review?(khuey)
Assignee: amarchesini → nsm.nikhil
Comment on attachment 8615694 [details]
MozReview Request: Bug 1168933 - Send referrer when downloading worker script. r?smaug

https://reviewboard.mozilla.org/r/10351/#review10451

Ship It!

::: dom/workers/ScriptLoader.cpp:194
(Diff revision 2)
> +  if (httpChannel) {

if (nsCOMPtr<nsI....)
https://hg.mozilla.org/mozilla-central/rev/d44bc296a927
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.