1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 1127398 ***

When patch for bug 1127398 is landed, user will be automatically navigated to existing 1-to-1 conversation when sending message from Participants view. Here are steps to reproduce the issue:

1. Have conversation with ContactA;
2. Have group conversation with ContactA and ContactB (send MMS to both contacts at the same time);
3. Enter group conversation and tap on header;
4. In Participants view tap on ContactA and choose "Send Message";
5. Observe Conversation view;

Expected result: user is correctly navigated to 1-to-1 conversation for ContactA;

Actual result: user sees messages from group conversations, while header states that we're in ContactA 1-to-1 conversation.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1127398-participants-send-message > mozilla-b2g:master

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8612196 [details] [review]
[gaia] azasypkin:bug-1127398-participants-send-message > mozilla-b2g:master

Hey Julien,

Asking for low-priority review here :)

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8612196 [details] [review]
[gaia] azasypkin:bug-1127398-participants-send-message > mozilla-b2g:master

yes, let's land this fix

Thanks !

Comment 4

[Oleg Zasypkin [:azasypkin]]

Thanks for review!

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30279

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 6

[Oleg Zasypkin [:azasypkin]]

Seems tree is open again.

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#4z-L1fXgQR2ePERW1PCFmQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[Oleg Zasypkin [:azasypkin]]

Last attempt and then will land manually since TreeHerder is green.

Comment 9

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#C3P6zxk4S6iqMnIrX3bHdw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 10

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30279

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 11

[Oleg Zasypkin [:azasypkin]]

Oops Autolander is not disabled yet (bug 1170554) :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/5ef5d283279c339b54a45c206e12b01ccb1c5b77