1169024 - [Video app] Device does not list all available videos on storage

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue on Flame 3.0

Description:
Flame 3.0 Video app lists a lot less number of videos comparing to how many videos are actually available on the SD card. This is also a regression from v2.2.

Prerequisites:
- Have an SD card that consists of ~65 videos. I use one containing 3gp, mp4, and ogv videos (a lot of them are duplicates, they just have different names. Not sure if it makes a difference).
- I didn't have any video file on internal memory to avoid making the issue more complicated

STR:
1) Flash to latest 3.0
2) Launch the video app
3) Count the number of videos

Expected: The number should match the number available on the SD card.

Actual: The number does not match the number on the SD card. For my case there are 65 videos on SD card, but it only lists 42 videos on video app.

Repro rate: 4/4

Attaching a logcat when first opening the video app after flashing.

Note:
I've not tested this on other app such as Gallery, since I've got a lot of photos on the SD card and didn't want to complicate the issue. It is possible this issue is global and not limited to Video app.

Device: Flame (KK, full flashed, 319MB)
BuildID: 20150527010201
Gaia: 8ca93673869a64e09ed6153c5402896822dfb253
Gecko: ff2e07228041
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Flame 2.2 is unaffected. Device lists all 65 video files on the SD card.

Device: Flame (KK, full flashed, 319MB)
BuildID: 20150527002504
Gaia: 8084264c4d1e28bc33220bc7443c7425bb76dbcc
Gecko: 19fcc06fb7ab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 2.2 so nominating this 3.0? The user should see all the videos that are stored on the sdcard in the video app.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The changes for Bug 1146729 seem to have caused this issue.

Mozilla-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150427015253
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150427020457
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 5fa88d413c4f
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 5fa88d413c4f

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60

Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fe832ef6cc60&tochange=5fa88d413c4f

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Blake, can you take a look at this please? This might have been caused by the landing for bug 1146729.

Comment 5

[Blake Wu [:bwu][:blakewu]]

Hi pewei,
Is it possible to provide one video file which cannot be listed in Video App?
Thanks!

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

I zipped all the videos I used and uploaded the zip here:

https://drive.google.com/file/d/0B2_oln1EM6iFblFWSzlSX2xkdVU/view?usp=sharing

I don't know if this would occur for a particular type of video file but I've noticed the app NOT listing all of the same type of video files.

Comment 7

[Blake Wu [:bwu][:blakewu]]

(In reply to Pi Wei Cheng [:piwei] from comment #6)
> I zipped all the videos I used and uploaded the zip here:
> 
> https://drive.google.com/file/d/0B2_oln1EM6iFblFWSzlSX2xkdVU/view?usp=sharing
> 
> I don't know if this would occur for a particular type of video file but
> I've noticed the app NOT listing all of the same type of video files.
Thanks for these files! 
So does video app stop loading after a while (like 5 mins) or it is trying to load/list all the video files and will not stop? I encounter the latter one.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

It does take a while to load, but eventually it will finish loading. I haven't exactly timed how long it takes to load, but I only start counting them after the blue animated loading bar is no longer displayed on the top.

Comment 9

[Blake Wu [:bwu][:blakewu]]

(In reply to Pi Wei Cheng [:piwei] from comment #8)
> It does take a while to load, but eventually it will finish loading. I
> haven't exactly timed how long it takes to load, but I only start counting
> them after the blue animated loading bar is no longer displayed on the top.
Thanks! I can see the same problem as you saw.

Comment 10

[Blake Wu [:bwu][:blakewu]]

I found VP8 sample.3gp in the zip-file shared in comment 6 is encoded in h.263 which is not supported yet in Gonk PDM, and that's one of files not shown in the video.

Comment 11

[Blake Wu [:bwu][:blakewu]]

Audio track in "TC#8485.mp4" in the zip-file shared in comment 6 is encoded in mp3 which is not supported in Gonk PDM. Bug 1174623 is created to support it.

Comment 12

[Blake Wu [:bwu][:blakewu]]

Attachment: Add debug-logs-for-checking-which-file-cannot-be-loaded.patch

Attach the gaia codes to add the some logs (adb logcat) to check which file cannot be loaded

Comment 13

[Blake Wu [:bwu][:blakewu]]

There are 66 files in the zipped file in comment 6. Two of them are mov files which FFOS doesn't support. After applying the patches in bug 1174166 and bug 1174623, I can see 64 files in the video APP.

Comment 14

[Blake Wu [:bwu][:blakewu]]

The patches in ug 1174166 and bug 1174623 have been landed.

Comment 15

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame. All 66 videos are listed in Video app with the link provided at comment 6.

Device: Flame (KK, full flashed, 319MB)
BuildID: 20150709010204
Gaia: fc6643dd3da2ccdf2ab284479643836bb3698644
Gecko: f34a7120f46b
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0