Closed Bug 1169034 Opened 9 years ago Closed 9 years ago

include <cstdlib> in ThreadStackHelper.cpp to declare correct overload for std::abs

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

include <cstdlib> in ThreadStackHelper.cpp to declare correct overload for std::abs
856 bytes, patch
jseward
: review+
Details | Diff | Splinter Review 
The integer-valued {,l,ll}abs functions come from <stdlib.h>, and so the
integer-valued overload for std::abs comes from <cstdlib>.
The integer-valued {,l,ll}abs functions come from <stdlib.h>, and so the
integer-valued overload for std::abs comes from <cstdlib>.
Attachment #8612389 - Flags: review?(jseward)
Attachment #8612389 - Flags: review?(jseward)
Attachment #8612389 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1764c92482b6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.