Closed Bug 1169039 Opened 4 years ago Closed 4 years ago
Check for Create
Effect call fails
ID2D1DeviceContext::CreateEffect() calls are going unchecked, and this could lead to using bad memory when the calls fail.
Handle NULL in case CreateEffect() fails and returns NULL.
Attachment #8612442 - Flags: feedback?(mstange)
Comment on attachment 8612442 [details] [diff] [review] create-effect-check.patch Please move the FilterSupport.cpp part of this patch to bug 1166585. And we don't need to gfxWarning() for those. For the DrawTargetD2D1.cpp checks, I think you should also check the return value of mDC->CreateEffect, as Milan suggested in the other bug.
Attachment #8612442 - Flags: feedback?(mstange) → feedback+
Forgot to add a commit message.
Attachment #8612484 - Flags: review?(mstange) → review+
You need to log in before you can comment on or make changes to this bug.