Closed Bug 1169039 Opened 4 years ago Closed 4 years ago

Check for CreateEffect call fails

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: kyle_fung, Assigned: kyle_fung)

Details

Attachments

(1 file, 2 obsolete files)

ID2D1DeviceContext::CreateEffect() calls are going unchecked, and this could lead to using bad memory when the calls fail.
Assignee: nobody → kfung
Attached patch create-effect-check.patch (obsolete) — Splinter Review
Handle NULL in case CreateEffect() fails and returns NULL.
Attachment #8612442 - Flags: feedback?(mstange)
Comment on attachment 8612442 [details] [diff] [review]
create-effect-check.patch

Please move the FilterSupport.cpp part of this patch to bug 1166585. And we don't need to gfxWarning() for those.

For the DrawTargetD2D1.cpp checks, I think you should also check the return value of mDC->CreateEffect, as Milan suggested in the other bug.
Attachment #8612442 - Flags: feedback?(mstange) → feedback+
Attached patch create-effect-check-v2.patch (obsolete) — Splinter Review
Attachment #8612442 - Attachment is obsolete: true
Forgot to add a commit message.
Attachment #8612482 - Attachment is obsolete: true
Attachment #8612484 - Flags: review?(mstange)
Attachment #8612484 - Flags: review?(mstange) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/215d220872d6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.