Closed
Bug 1169039
Opened 10 years ago
Closed 10 years ago
Check for CreateEffect call fails
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: kyle_fung, Assigned: kyle_fung)
Details
Attachments
(1 file, 2 obsolete files)
|
6.14 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
ID2D1DeviceContext::CreateEffect() calls are going unchecked, and this could lead to using bad memory when the calls fail.
Handle NULL in case CreateEffect() fails and returns NULL.
Attachment #8612442 -
Flags: feedback?(mstange)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8612442 [details] [diff] [review]
create-effect-check.patch
Please move the FilterSupport.cpp part of this patch to bug 1166585. And we don't need to gfxWarning() for those.
For the DrawTargetD2D1.cpp checks, I think you should also check the return value of mDC->CreateEffect, as Milan suggested in the other bug.
Attachment #8612442 -
Flags: feedback?(mstange) → feedback+
Attachment #8612442 -
Attachment is obsolete: true
Forgot to add a commit message.
Attachment #8612482 -
Attachment is obsolete: true
Attachment #8612484 -
Flags: review?(mstange)
|
|
||
Updated•10 years ago
|
Attachment #8612484 -
Flags: review?(mstange) → review+
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•