Closed
Bug 1169075
Opened 11 years ago
Closed 11 years ago
Highlight elements when tapped
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
Since adding back our custom context menu, elements aren't highlighted on the page when touched.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8611549 -
Flags: review?(sarentz)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8611549 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/509
This looks great. It is very nice to have a visual feedback. I see you set the borderRadius but I don't actually see that. Or maybe it is hard to see. I would just file a followup for visual tweaks if needed.
Attachment #8611549 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I'm with wesj in that handling this with injected DOM listeners feels sketchy, but I'm not sure if we have any good alternatives. Let's land this ASAP so it can be in tonight's build, which will hopefully give us some beta tester feedback.
https://github.com/mozilla/firefox-ios/commit/315a6aad47d97a0e05a5b55532a282fd8087a769
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
tracking-fennec: ? → +
tracking-fxios:
--- → +
You need to log in
before you can comment on or make changes to this bug.
Description
•