1169150 - [Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

In this patch we will discuss the name of the threads module and commit in our codebase. And we might need a simple script to update lib easily.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8612117 [details] [review]
[gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

Tiny patch that simply download the lib by bower and warp with fixed name "bridge" and fixed path(lib/bridge.js). Please let me know if you prefer more flexibility about the script(download specific version of threads, ability to set other name for lib...)/other name/path for lib/keep the bower component.

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8612117 [details] [review]
[gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

Looks good enough for me, it will either be improved or entirely removed in the future anyway.

Only wish is to be able to run this script from any directory (like root gaia folder), but it's not that critical.

It unblocks our services work right now and that's all I need :) 

Thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8612117 [details] [review]
[gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

I added some comments for the shell script. But this is about what I have in mind.

Thanks !

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8612117 [details] [review]
[gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

Move the script under tools/ (but it will need to have another .bowerrc if wee need a specific path for bower component) with suggestions addressed, thanks!

BTW I agree it might be more convenient if we can execute script from anywhere, but I have no better idea than adding PATH to bashrc :p

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8612117 [details] [review]
[gaia] steveck-chung:new-message-threads-lib > mozilla-b2g:master

I don't think we need the .bowerrc if we run the script from the "sms" directory. I'll think of a way to move to the right directory later, but let's unblock the other work :)

Comment 7

[Julien Wajsberg [:julienw]]

Please remove the .bowerrc (after checking whether this works when running from the "sms" directory).

Maybe file a separate bug for the additional work (moving to the right directory if we're not there), I'll find something :)

Comment 8

[Steve Chung [:steveck]]

Thanks for the review! I create a follow up for the subfolder and let's move forward.

In master : https://github.com/mozilla-b2g/gaia/commit/63233508824132bff0f2b14222a83a54ca94b8f3