1169151 - AccessibleCaret remains on the screen when long tapping an empty input

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: 2015-05-28.png

Steps to reproduce:
1. Open message app to compose a new message.
2. Type some text into the body.
3. Long tap to select a word on the text body.
4. Long tap on the *empty* "To:" field.

Actual result:
The AccessibleCaret remains on the screen.

Expected result:
The AccessibleCaret should disappear.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Update carets after long tapping on empty input. (v1)

This fixed AccessibleCarets remain on the screen when long tapping on an
empty input.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8612187 [details] [diff] [review]
Update carets after long tapping on empty input. (v1)

Review of attachment 8612187 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this change would send one additional mozcaretstatechangeevent because it call UpdateCaret one more time. I'm not sure whether this change will affect copy/paste bubble behavior or not. r=me if the copy/paste bubble works correctly after applying this patch.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

BTW, you can apply bug 1147329 for testing new bubble.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I've tested with bug 1147329. The new bubble behavior is not affected by the extra mozcaretstatechangeevent. The bubble is still correct whether we have previously copied some text or not.

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c755a9dc3de

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2b4b7136b57

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2b4b7136b57