Closed Bug 1169158 Opened 8 years ago Closed 8 years ago

Avoid NSPR using dates it generates at build time

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

The NSPR build system uses a "now" binary, as well as "date" to generate dates it puts in structures it exposes through public APIs. I don't want to think too much about backwards compatibility with hypothetical third party stuff that would be relying on those structures.

Thankfully, we can do something on our end.
Yeah, that's quite horrible, but I don't want to have to deal with the consequences of modifying NSPR.
Attachment #8612128 - Flags: review?(gps)
Comment on attachment 8612128 [details] [diff] [review]
Avoid NSPR using dates it generates at build time

Review of attachment 8612128 [details] [diff] [review]:
-----------------------------------------------------------------

That's "fun" make syntax. I'd almost feel better if this were a one-off variable in config.status. But it doesn't seem worth it for a single use variable. Meh.
Attachment #8612128 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/739e16f56c90
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.