1169158 - Avoid NSPR using dates it generates at build time

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The NSPR build system uses a "now" binary, as well as "date" to generate dates it puts in structures it exposes through public APIs. I don't want to think too much about backwards compatibility with hypothetical third party stuff that would be relying on those structures.

Thankfully, we can do something on our end.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid NSPR using dates it generates at build time

Yeah, that's quite horrible, but I don't want to have to deal with the consequences of modifying NSPR.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8612128 [details] [diff] [review]
Avoid NSPR using dates it generates at build time

Review of attachment 8612128 [details] [diff] [review]:
-----------------------------------------------------------------

That's "fun" make syntax. I'd almost feel better if this were a one-off variable in config.status. But it doesn't seem worth it for a single use variable. Meh.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/739e16f56c90

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/739e16f56c90