1169160 - [MobileConnection] Support more call barring program: all service, outgoing service and incoming service

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Now only MMI supports these three call barring program: all service, outgoing service and incoming service. I think we should also make it available on web api and service interface.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Aknow, Hsinyi, may I have your review? Thank you.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: dom/mobileconnection/tests/marionette/test_call_barring_basic_operations.js
@@ +90,5 @@
>    }, Promise.resolve());
>  }
>  
> +function testUnsupportedPrograms() {
> +  // Emulator now doesn't support these three program.

program's'

@@ +91,5 @@
>  }
>  
> +function testUnsupportedPrograms() {
> +  // Emulator now doesn't support these three program.
> +  let unsupportedProgram =

unsupportedProgram's'

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you!

Comment 5

[Edgar Chen [:edgar]]

Attachment: Patch, v2, r=hsinyi,aknow

Address review comment #3.

Comment 6

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8b4d0e4a018

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/ad0828fe3559

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad0828fe3559