Closed Bug 1169160 Opened 7 years ago Closed 7 years ago

[MobileConnection] Support more call barring program: all service, outgoing service and incoming service

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file, 1 obsolete file)

Now only MMI supports these three call barring program: all service, outgoing service and incoming service. I think we should also make it available on web api and service interface.
Blocks: 1159591
Attached patch Patch, v1 (obsolete) — Splinter Review
Assignee: nobody → echen
Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Aknow, Hsinyi, may I have your review? Thank you.
Attachment #8612223 - Flags: review?(szchen)
Attachment #8612223 - Flags: review?(htsai)
Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: dom/mobileconnection/tests/marionette/test_call_barring_basic_operations.js
@@ +90,5 @@
>    }, Promise.resolve());
>  }
>  
> +function testUnsupportedPrograms() {
> +  // Emulator now doesn't support these three program.

program's'

@@ +91,5 @@
>  }
>  
> +function testUnsupportedPrograms() {
> +  // Emulator now doesn't support these three program.
> +  let unsupportedProgram =

unsupportedProgram's'
Attachment #8612223 - Flags: review?(szchen) → review+
Comment on attachment 8612223 [details] [diff] [review]
Patch, v1

Review of attachment 8612223 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you!
Attachment #8612223 - Flags: review?(htsai) → review+
Address review comment #3.
Attachment #8612223 - Attachment is obsolete: true
Attachment #8614704 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/ad0828fe3559
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.