1169196 - Images with srcset attribute not being blocked by permissions.default.image

Status: RESOLVED DUPLICATE of bug 1196784

(Core :: Graphics: Image Blocking, defect)

Description

[Kestrel]

Steps to reproduce:

1. Block all images by setting permissions.default.image = 2.
2. Visit http://en.wikipedia.org/wiki/Mozilla_Firefox
3. Note images with srcset attribute are still being loaded.

Comment 1

[M8R-p7]

This affects <picture> too, both for srcset and for when an IMG is used as a fallback.

JSFiddle-based test: http://jsfiddle.net/zm8uk7g2/

Comment 2

[Nicolas Silva [:nical]]

Timothy, are you the right person to look into this? If not do you know who is ?

Comment 3

[Timothy Nikkel (:tnikkel)]

The only references to the pref "permissions.default.image" in the code are in js files, so I'm assuming this feature is implemented in the front end. So redirecting needinfo to someone who works on the frontend.

Comment 4

[Justin Dolske [:Dolske]]

This is the old "Load images automatically" that we mostly removed front-end support for (see http://limi.net/checkboxes-that-kill/), most of the leftovers in MXR are for the profile importers (which I think there's a separate bug for killing).

AFAIK this should still work via nsContentBlocker::TestPermission()'s call to the goop in nsPermissionManager. (You can see some even older cruft in nsContentBlocker::Init) Presumably something isn't calling that?

Comment 5

[[e-mail]]

Bug 1196784 which also got filed on this seems to have gathered slightly more useful comments so it's probably better to forward-duplicate this one to that one.